Fix a problem with using the Google ChromeDriver not getting sessionId

docker-compose.yml

@@ -1,5 +1,10 @@
 version: '2'
 services:
+    chrome:
+        image: robcherry/docker-chromedriver:latest
+        environment:
+            CHROMEDRIVER_WHITELISTED_IPS: ""
+
     geckodriver:
         image: quay.io/cvlibrary/geckodriver
         logging:
@@ -15,6 +20,20 @@ services:
         depends_on:
             - geckodriver
             - httpd
+        environment:
+            WEBDRIVER_HOST: geckodriver
+            WEBDRIVER_CAPABILITIES: '{ "moz:firefoxOptions" : { "args" : ["-headless"] } }'
+        volumes:
+            - .:/root
+
+    test-chrome:
+        build: .
+        depends_on:
+            - chrome
+            - httpd
+        environment:
+            WEBDRIVER_HOST: chrome
+            WEBDRIVER_CAPABILITIES: '{ "chromeOptions" : { "binary" : "/usr/bin/google-chrome", "args": ["--headless"] } }'
         volumes:
             - .:/root
 

lib/WebDriver/Tiny.pm

@@ -82,8 +82,10 @@ sub new($class, %args) {
         $args{base_url} // '',
     ], $class;
 
+    my $req_args = { desiredCapabilities => $args{capabilities} // {} };
+    $req_args->{_need_sessionId} = 1;
     my $reply = $self->_req(
-        POST => '', { desiredCapabilities => $args{capabilities} // {} } );
+        POST => '', $req_args );
 
     $self->[1] .= '/' . $reply->{sessionId};
 
@@ -274,14 +276,18 @@ sub window_switch($self, $handle) {
     $self;
 }
 
-sub _req($self, $method, $path, $args = undef) {
+sub _req($self, $method, $path, $args = {}) {
+    my $need_sessionId = delete $args->{_need_sessionId};
+
     my $reply = $self->[0]->request(
         $method,
         $self->[1] . $path,
-        { content => JSON::PP::encode_json( $args // {} ) },
+        { content => JSON::PP::encode_json( $args ) },
     );
 
-    my $value = eval { JSON::PP::decode_json( $reply->{content} )->{value} };
+    my $full_value = eval { JSON::PP::decode_json( $reply->{content} ) };
+    my $value = $full_value->{value};
+    $value->{sessionId} //= $full_value->{sessionId} if $need_sessionId;
 
     unless ( $reply->{success} ) {
         my $error = $value

run-xt

@@ -1,8 +1,10 @@
 #!/bin/sh
 
-docker-compose up --abort-on-container-exit --build --exit-code-from test -t0
-
+docker-compose run --rm test
 ret=$?
+docker-compose run --rm test-chrome
+
+ret=$? && $ret
 
 docker-compose kill  &> /dev/null
 docker-compose rm -f &> /dev/null

xt/alert.t

@@ -1,12 +1,13 @@
 use strict;
 use warnings;
 
+use JSON::PP ();
 use Test::More;
 use WebDriver::Tiny;
 
 my $drv = WebDriver::Tiny->new(
-    capabilities => { 'moz:firefoxOptions' => { args => ['-headless'] } },
-    host         => 'geckodriver',
+    capabilities => JSON::PP::decode_json($ENV{WEBDRIVER_CAPABILITIES} || '{}'),
+    host         => $ENV{WEBDRIVER_HOST},
     port         => 4444,
 );
 

xt/attr.t

@@ -1,13 +1,14 @@
 use strict;
 use warnings;
 
+use JSON::PP ();
 use Test::Deep;
 use Test::More;
 use WebDriver::Tiny;
 
 my $drv = WebDriver::Tiny->new(
-    capabilities => { 'moz:firefoxOptions' => { args => ['-headless'] } },
-    host         => 'geckodriver',
+    capabilities => JSON::PP::decode_json($ENV{WEBDRIVER_CAPABILITIES} || '{}'),
+    host         => $ENV{WEBDRIVER_HOST},
     port         => 4444,
 );
 

xt/basic.t

@@ -2,13 +2,14 @@ use strict;
 use utf8;
 use warnings;
 
+use JSON::PP ();
 use Test::Deep;
 use Test::More;
 use WebDriver::Tiny;
 
 my $drv = WebDriver::Tiny->new(
-    capabilities => { 'moz:firefoxOptions' => { args => ['-headless'] } },
-    host         => 'geckodriver',
+    capabilities => JSON::PP::decode_json($ENV{WEBDRIVER_CAPABILITIES} || '{}'),
+    host         => $ENV{WEBDRIVER_HOST},
     port         => 4444,
 );
 

xt/cookies.t

@@ -1,12 +1,13 @@
 use strict;
 use warnings;
 
+use JSON::PP ();
 use Test::More;
 use WebDriver::Tiny;
 
 my $drv = WebDriver::Tiny->new(
-    capabilities => { 'moz:firefoxOptions' => { args => ['-headless'] } },
-    host         => 'geckodriver',
+    capabilities => JSON::PP::decode_json($ENV{WEBDRIVER_CAPABILITIES} || '{}'),
+    host         => $ENV{WEBDRIVER_HOST},
     port         => 4444,
 );
 

xt/form.t

@@ -2,6 +2,7 @@ use strict;
 use utf8;
 use warnings;
 
+use JSON::PP ();
 use Test::Deep;
 use Test::More;
 use URI;
@@ -15,8 +16,8 @@ sub pick { map { splice @_, rand @_, 1 } 1 .. shift }
 sub roll { map { $_[ rand @_ ]         } 1 .. shift }
 
 my $drv = WebDriver::Tiny->new(
-    capabilities => { 'moz:firefoxOptions' => { args => ['-headless'] } },
-    host         => 'geckodriver',
+    capabilities => JSON::PP::decode_json($ENV{WEBDRIVER_CAPABILITIES} || '{}'),
+    host         => $ENV{WEBDRIVER_HOST},
     port         => 4444,
 );
 

xt/ghost.t

@@ -2,12 +2,13 @@ use strict;
 use utf8;
 use warnings;
 
+use JSON::PP ();
 use Test::More;
 use WebDriver::Tiny;
 
 my $drv = WebDriver::Tiny->new(
-    capabilities => { 'moz:firefoxOptions' => { args => ['-headless'] } },
-    host         => 'geckodriver',
+    capabilities => JSON::PP::decode_json($ENV{WEBDRIVER_CAPABILITIES} || '{}'),
+    host         => $ENV{WEBDRIVER_HOST},
     port         => 4444,
 );
 

xt/javascript.t

@@ -1,12 +1,13 @@
 use strict;
 use warnings;
 
+use JSON::PP ();
 use Test::More;
 use WebDriver::Tiny;
 
 my $drv = WebDriver::Tiny->new(
-    capabilities => { 'moz:firefoxOptions' => { args => ['-headless'] } },
-    host         => 'geckodriver',
+    capabilities => JSON::PP::decode_json($ENV{WEBDRIVER_CAPABILITIES} || '{}'),
+    host         => $ENV{WEBDRIVER_HOST},
     port         => 4444,
 );
 

xt/screenshot.t

@@ -1,13 +1,14 @@
 use strict;
 use warnings;
 
+use JSON::PP ();
 use File::Temp;
 use Test::More;
 use WebDriver::Tiny;
 
 my $drv = WebDriver::Tiny->new(
-    capabilities => { 'moz:firefoxOptions' => { args => ['-headless'] } },
-    host         => 'geckodriver',
+    capabilities => JSON::PP::decode_json($ENV{WEBDRIVER_CAPABILITIES} || '{}'),
+    host         => $ENV{WEBDRIVER_HOST},
     port         => 4444,
 );
 

xt/status.t

@@ -1,13 +1,14 @@
 use strict;
 use warnings;
 
+use JSON::PP ();
 use Test::Deep;
 use Test::More;
 use WebDriver::Tiny;
 
 my $drv = WebDriver::Tiny->new(
-    capabilities => { 'moz:firefoxOptions' => { args => ['-headless'] } },
-    host         => 'geckodriver',
+    capabilities => JSON::PP::decode_json($ENV{WEBDRIVER_CAPABILITIES} || '{}'),
+    host         => $ENV{WEBDRIVER_HOST},
     port         => 4444,
 );
 

xt/window-management.t

@@ -1,13 +1,14 @@
 use strict;
 use warnings;
 
+use JSON::PP ();
 use Test::Deep;
 use Test::More;
 use WebDriver::Tiny;
 
 my $drv = WebDriver::Tiny->new(
-    capabilities => { 'moz:firefoxOptions' => { args => ['-headless'] } },
-    host         => 'geckodriver',
+    capabilities => JSON::PP::decode_json($ENV{WEBDRIVER_CAPABILITIES} || '{}'),
+    host         => $ENV{WEBDRIVER_HOST},
     port         => 4444,
 );