Skip to content

🔒 Fix hardcoded credentials in MinIO Dockerfile#61

Merged
damacus merged 1 commit into
mainfrom
fix/remove-hardcoded-minio-credentials-120342227862314319
May 12, 2026
Merged

🔒 Fix hardcoded credentials in MinIO Dockerfile#61
damacus merged 1 commit into
mainfrom
fix/remove-hardcoded-minio-credentials-120342227862314319

Conversation

@damacus
Copy link
Copy Markdown
Owner

@damacus damacus commented May 11, 2026

🎯 What: The MINIO_ROOT_USER and MINIO_ROOT_PASSWORD were hardcoded as ARGs and exposed via the MC_HOST_local ENV in the docker/minio/Dockerfile.
⚠️ Risk: Hardcoding credentials inside a Dockerfile means they are permanently baked into the image layers, leading to significant risk of unauthorized access.
🛡️ Solution: Removed the ARG and ENV parameters from docker/minio/Dockerfile. Modified docker-compose.yml to supply these parameters securely as runtime environment variables, and updated .env.example to provide placeholders.


PR created automatically by Jules for task 120342227862314319 started by @damacus

Co-authored-by: damacus <40786+damacus@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@damacus damacus merged commit 38dadaf into main May 12, 2026
4 checks passed
@damacus damacus deleted the fix/remove-hardcoded-minio-credentials-120342227862314319 branch May 12, 2026 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant