Skip to content

🔒 Fix hardcoded credentials in MinIO Dockerfile #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
damacus merged 1 commit into from
May 12, 2026
Merged

🔒 Fix hardcoded credentials in MinIO Dockerfile #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .env.example
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,5 @@
# - localhost:9000 (local development)
# - minio.example.com:9000 (production)
MINIO_ENDPOINT=play.min.io:9000
MINIO_ROOT_USER=your_admin_user
MINIO_ROOT_PASSWORD=your_admin_password
6 changes: 4 additions & 2 deletions docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,10 @@ x-minio-common: &minio-common
dockerfile: Dockerfile
args:
MINIO_VERSION: RELEASE.2025-10-15T17-29-55Z
MINIO_ROOT_USER: minioadmin
MINIO_ROOT_PASSWORD: minioadmin
environment:
- MINIO_ROOT_USER=${MINIO_ROOT_USER}
- MINIO_ROOT_PASSWORD=${MINIO_ROOT_PASSWORD}
- MC_HOST_local=http://${MINIO_ROOT_USER}:${MINIO_ROOT_PASSWORD}@localhost:9000
command: server --console-address ":9001" http://minio{1...4}/data
healthcheck:
test: ["CMD", "mc", "ready", "local"]
Expand Down
3 changes: 0 additions & 3 deletions docker/minio/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
FROM alpine:3.23
ARG TARGETARCH
ARG MINIO_ROOT_USER=minioadmin
ARG MINIO_ROOT_PASSWORD=minioadmin

RUN apk add --no-cache ca-certificates wget && \
case "${TARGETARCH}" in amd64|arm64) ;; *) echo "unsupported architecture: ${TARGETARCH}" && exit 1 ;; esac && \
Expand All @@ -12,7 +10,6 @@ RUN apk add --no-cache ca-certificates wget && \
mkdir -p /data && \
chown -R minio:minio /data

ENV MC_HOST_local=http://${MINIO_ROOT_USER}:${MINIO_ROOT_PASSWORD}@localhost:9000

USER minio
EXPOSE 9000 9001
Expand Down