Add more widgets to QAP by default #16656
Conversation
This allows the user to change the type of illuminant and have full control directly on the QAP no matter which type of illuminant is selected.
ralfbrown
added
wip
|
@ralfbrown : A screenshot please? |
|
|
|
I don't think it is good to propose here Sigmoid & Filmic at the same time. Either Filmic or Sigmoid should be added depending on the current workflow setting. Also I would reorder the modules to be on the order it should be used. For example in the scene-referred workflow we recommend to set the exposure early, but the module is far down here. Same for color calibration (at least WB) should come early. That being said I'm quite happy to see this proposal, I like the idea of having a ready to use for basic development covering most needs. |
Sounds like a good addition to me. |
That's fine, I just need to figure out how to distinguish which is in the workflow.
As with all of the right-hand panels, the display order reflects the pipeline order.... |
also add global brilliance slider from colorbalancergb. Note that a restart is required for a changed workflow setting to show in the QAP.
Oh my bad, I really thought that the order was forced in this panel. Makes sense... |
Also, I was mistaken about needing a restart on changing workflows - it is only necessary to leave and then re-enter darkroom view.
ralfbrown
changed the title
TurboGit
added
documentation-pending
elstoc
added
documentation-pending
|
Updated QAP screenshot in darktable-org/dtdocs#697. |
And before everyone jumps on me for making the panel require scrolling, I'm aware of that but think it's warranted to get all of the main editing functions that new users might end up using into one place. It's probably also better to err a little on the side of adding too many (e.g. having both Filmic and Sigmoid by default) since it's easier to remove widgets than to add them -- plus most users of any software never change defaults. The scrolling issue could be mitigated by switching the default preference to scrolling the panel instead of adjusting sliders; in that case we should consider adding a hint about using Alt-Scroll to the slider tooltips.
I've separated the additions into a bunch of small commits to permit easy cherrypicking. If all of them are included, we get full color and tonal control (including global and local contrast) as well as denoising control right from the panel.
Two other things I would like to add: binding the Escape key to activating the QAP (to return there after linking out to a full module), and adding the preset menu for each module next to the link button. I haven't figured out how to do the former in code yet, though it works quite well when done manually in the UI via the mapping function (changing the action from the default "toggle" to "on"). I haven't had a chance to look into the latter yet.
A dedicated return to the exact position in the QAP from which one jumped to a full module would be better (though more work) than a shortcut to activate the QAP, since the latter action always leaves you at the top instead of preserving the scroll position.