Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more widgets to QAP by default #16656

Merged
merged 9 commits into from
Apr 27, 2024
Merged

Add more widgets to QAP by default #16656

Changes from 8 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
99f8a42
add sigmoid contrast and skew as default widgets
ralfbrown Apr 20, 2024
98aa924
add colorequalizer (page, graph, and node placement) as default on QAP
ralfbrown Apr 20, 2024
796accc
add local contrast 'detail' slider as default widget on QAP
ralfbrown Apr 20, 2024
a394155
add color calibration 'illuminant', 'F source', and 'LED source' widgets
ralfbrown Apr 20, 2024
b4b5b75
add denoise(profiles) 'strength' slider to QAP
ralfbrown Apr 20, 2024
a301547
add tone equalizer (graph and both compensation sliders) to QAP
ralfbrown Apr 20, 2024
20e25df
update copyright date
ralfbrown Apr 20, 2024
d6e3ca8
use either filmic or sigmoid, depending on workflow setting
ralfbrown Apr 20, 2024
1121373
style changes
ralfbrown Apr 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 23 additions & 7 deletions src/libs/modulegroups.c
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/*
This file is part of darktable,
Copyright (C) 2011-2022 darktable developers.
Copyright (C) 2011-2024 darktable developers.

darktable is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
Expand Down Expand Up @@ -1479,27 +1479,42 @@ static void _preset_from_string(dt_lib_module_t *self, gchar *txt, gboolean edit
tx = g_strdup_printf("1|0ꬹ1||"); \
if(is_scene_referred) \
{ \
AM("filmicrgb/white relative exposure"); \
AM("filmicrgb/black relative exposure"); \
AM("filmicrgb/contrast"); \
if(wf_filmic) { \
ralfbrown marked this conversation as resolved.
Show resolved Hide resolved
AM("filmicrgb/white relative exposure"); \
AM("filmicrgb/black relative exposure"); \
AM("filmicrgb/contrast"); \
} else if (wf_sigmoid) { \
ralfbrown marked this conversation as resolved.
Show resolved Hide resolved
AM("sigmoid/contrast"); \
AM("sigmoid/skew"); \
} \
AM("channelmixerrgb/temperature"); \
AM("channelmixerrgb/chroma"); \
AM("channelmixerrgb/hue"); \
AM("channelmixerrgb/illuminant"); \
AM("channelmixerrgb/F source"); \
AM("channelmixerrgb/LED source"); \
} \
else \
{ \
AM("temperature/temperature"); \
AM("temperature/tint"); \
} \
AM("colorequal/page"); \
AM("colorequal/graph"); \
AM("colorequal/node placement"); \
AM("exposure/exposure"); \
if(!is_scene_referred) AM("colorbalancergb/contrast"); /* contrast is already in filmic */ \
if(!is_scene_referred) AM("colorbalancergb/contrast"); /* contrast is already in filmic/sigmoid */ \
AM("colorbalancergb/global chroma"); \
AM("colorbalancergb/global vibrance"); \
AM("colorbalancergb/global saturation"); \
AM("colorbalancergb/global brilliance"); \
AM("ashift/rotation"); \
AM("denoiseprofile"); \
AM("denoiseprofile/strength"); \
AM("toneequal/graph"); \
AM("toneequal/mask exposure compensation"); \
AM("toneequal/mask contrast compensation"); \
AM("lens"); \
AM("bilat"); \
AM("bilat/detail"); \
}

// start module group
Expand Down Expand Up @@ -1797,6 +1812,7 @@ static gchar *_presets_get_minimal(dt_lib_module_t *self)
{
const gboolean is_scene_referred = dt_is_scene_referred();
const gboolean wf_filmic = dt_conf_is_equal("plugins/darkroom/workflow", "scene-referred (filmic)");
const gboolean wf_sigmoid = dt_conf_is_equal("plugins/darkroom/workflow", "scene-referred (sigmoid)");

// all modules
gchar *tx = NULL;
Expand Down