chore: fix misleading comment about CTAS and allow_append_only_skip
#19189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr-chore
Previous comments about the behavior of CommitSink::allow_append_only_skip were incorrect. In fact, CTAS operations are allowed to skip the update_table_meta operation inside CommitSink if no data is inserted to the target table.
dantengsky
force-pushed
the
chore-fix-code-comment
branch
from
a5658bb to
9312def
Compare
SkyFan2002
approved these changes
Jan 4, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
Previous comments about the behavior of
CommitSink::allow_append_only_skipwere incorrect. In fact,CTAS operations are allowed to skip the
update_table_metaoperation inside CommitSink if no datais inserted to the target table.
Tests
Type of change
This change is