Skip to content

chore: fix misleading comment about CTAS and allow_append_only_skip #19189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SkyFan2002 merged 1 commit into from
Jan 4, 2026
Merged

chore: fix misleading comment about CTAS and allow_append_only_skip #19189

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/query/storages/fuse/src/operations/common/processors/sink_commit.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,10 +386,9 @@ where F: SnapshotGenerator + Send + Sync + 'static
.is_some()
}

/// Append-only inserts (e.g. `INSERT INTO t SELECT ...`) may skip committing if
/// nothing was written. Overwrite/CTAS (`CREATE OR REPLACE TABLE t AS SELECT ...`
/// or `INSERT OVERWRITE ...`) still need a snapshot even when nothing was written,
/// so we disable skipping when `AppendGenerator` is in overwrite mode.
/// Append-only inserts (e.g. `INSERT INTO t SELECT ...`) may skip committing if nothing was
/// written. `INSERT OVERWRITE ...` still need a snapshot even when nothing was written, so we
/// disable skipping when `AppendGenerator` is in overwrite mode.
fn allow_append_only_skip(&self) -> bool {
self.snapshot_gen
.as_any()
Expand Down
Loading