change log message on successful recon aggregate runs #2040
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-abulazm
added
bug
|
✅ 27/27 passed, 2 flaky, 1m28s total Flaky tests:
Running from acceptance #2327 |
gueniai
added a commit
that referenced
this pull request
Sep 25, 2025
## Analyzer - **Large XML file chunking optimization**: Now the analyzer is able to handle large XML files (up to 1TB in size) ## Converters ### General - **Non-interactive transpiler installation**: Introduced support for non-interactive installation mode with new `interactive` option that can detect environment context, enabling automated installations without user input while preserving existing configurations. Resolves [#2013](#2013) ### Morpheus - **Enhanced GRANT statement support**: Implemented comprehensive GRANT statement support by creating dedicated `permission.g4` grammar file with IR definitions and translation rules for permission-related statements - **Improved error handling**: Rewrote print function to properly handle newlines and added extensive unit tests for error annotation, including block and FIXME comments. Resolves [#2030](#2030) - **Enhanced LSP server behavior**: Improved LSP server to append original text to error messages when transpilation fails, eliminating need for client-side response manipulation - **Standardized dialect options**: Aligned dialect options to present `synapse` and `mssql` to users for consistency with bladebridge - **Fixed Lateral Column Alias handling**: Enhanced dealiasing for Lateral Column Aliases (LCAs) in WHERE clauses under CASE...WHEN expressions. Resolves [#1767](#1767) - **Enhanced GROUP BY/aggregation function dealiasing**: Implemented dealiasing for Lateral Column Aliases in GROUP BY clauses and aggregation functions where LCA references are unsupported. Resolves ([https://github.com/databrickslabs/lakebridge/issues/956](https://github.com/databrickslabs/lakebridge/issues/956)) and ([https://github.com/databrickslabs/lakebridge/issues/954](https://github.com/databrickslabs/lakebridge/issues/954)) - **Optimized Snowflake transformations**: Reordered transformation rules to ensure `TransformWithinGroup` processes all cases before the call mapper. Resolves [#1231](#1231) ### BladeBridge - **Enhanced merge statement handlers**: Improved merge statement processing to fix backtick handling, update operations without WHERE clauses, procedure conversions, IF-THEN-SET blocks, and various delimiter and mapping issues - **Fixed view creation with WITH clauses**: Corrected CREATE VIEW functionality to properly handle WITH clause statements - **Oracle script improvements**: Resolved variable declaration issues in Oracle scripts containing exception handling blocks - **SQL Server function mapping**: Added function mappings for Microsoft SQL Server functions including GETUTCDATE, IS_MEMBER, SERVERPROPERTY variants, and QUOTENAME with one or two arguments - **Fixed variable declarations**: Resolved variable declaration issues in Oracle scripts that contain exception handling blocks - MSSQL Server **Enhanced function mappings**: Added comprehensive function mappings including GETUTCDATE, IS_MEMBER, SERVERPROPERTY variants, and QUOTENAME with one or two arguments ## Reconcile - **Improved logging for aggregate reconciliation**: Enhanced logging functionality to provide more accurate messages by replacing warning logs with informational messages when aggregate details rules are empty, indicating successful reconciliation with no details to store. Resolves [#2040](#2040) - **Refactored aggregate query building**: Simplified code using `AggregateQueryBuilder` class to generate queries for both source and target in a more concise and efficient manner ## Documentation No updates in this release ## Dependency updates: * Bump actions/setup-python from 5 to 6 ([#1988](#1988)).
Merged
gueniai
added a commit
that referenced
this pull request
Sep 25, 2025
## Analyzer
- **Large XML file chunking optimization**: Now the analyzer is able to
handle large XML files (up to 1TB in size)
## Converters
### General
- **Non-interactive transpiler installation**: Introduced support for
non-interactive installation mode with new `interactive` option that can
detect environment context, enabling automated installations without
user input while preserving existing configurations.
Resolves [#2013](#2013)
### Morpheus
- **Enhanced GRANT statement support**: Implemented comprehensive GRANT
statement support by creating dedicated `permission.g4` grammar file
with IR definitions and translation rules for permission-related
statements
- **Improved error handling**: Rewrote print function to properly handle
newlines and added extensive unit tests for error annotation, including
block and FIXME comments.
Resolves [#2030](#2030)
- **Enhanced LSP server behavior**: Improved LSP server to append
original text to error messages when transpilation fails, eliminating
need for client-side response manipulation
- **Standardized dialect options**: Aligned dialect options to
present `synapse` and `mssql` to users for consistency with bladebridge
- **Fixed Lateral Column Alias handling**: Enhanced dealiasing for
Lateral Column Aliases (LCAs) in WHERE clauses under CASE...WHEN
expressions.
Resolves [#1767](#1767)
- **Enhanced GROUP BY/aggregation function dealiasing**: Implemented
dealiasing for Lateral Column Aliases in GROUP BY clauses and
aggregation functions where LCA references are unsupported. Resolves
([https://github.com/databrickslabs/lakebridge/issues/956](https://github.com/databrickslabs/lakebridge/issues/956))
and
([https://github.com/databrickslabs/lakebridge/issues/954](https://github.com/databrickslabs/lakebridge/issues/954))
- **Optimized Snowflake transformations**: Reordered transformation
rules to ensure `TransformWithinGroup` processes all cases before the
call mapper.
Resolves [#1231](#1231)
### BladeBridge
- **Enhanced merge statement handlers**: Improved merge statement
processing to fix backtick handling, update operations without WHERE
clauses, procedure conversions, IF-THEN-SET blocks, and various
delimiter and mapping issues
- **Fixed view creation with WITH clauses**: Corrected CREATE VIEW
functionality to properly handle WITH clause statements
- **Oracle script improvements**: Resolved variable declaration issues
in Oracle scripts containing exception handling blocks
- **SQL Server function mapping**: Added function mappings for Microsoft
SQL Server functions including GETUTCDATE, IS_MEMBER, SERVERPROPERTY
variants, and QUOTENAME with one or two arguments
- **Fixed variable declarations**: Resolved variable declaration issues
in Oracle scripts that contain exception handling blocks
- MSSQL Server **Enhanced function mappings**: Added comprehensive
function mappings including GETUTCDATE, IS_MEMBER, SERVERPROPERTY
variants, and QUOTENAME with one or two arguments
## Reconcile
- **Improved logging for aggregate reconciliation**: Enhanced logging
functionality to provide more accurate messages by replacing warning
logs with informational messages when aggregate details rules are empty,
indicating successful reconciliation with no details to store.
Resolves [#2040](#2040)
- **Refactored aggregate query building**: Simplified code
using `AggregateQueryBuilder` class to generate queries for both source
and target in a more concise and efficient manner
## Documentation
No updates in this release
## Dependency updates:
* Bump actions/setup-python from 5 to 6
([#1988](#1988)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
What does this PR do?
change wrong log message and change level on successful reconcile aggregate runs
Resolves #1426