Skip to content

change log message on successful recon aggregate runs #2040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2025
Merged

change log message on successful recon aggregate runs #2040

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/databricks/labs/lakebridge/reconcile/recon_capture.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -579,7 +579,13 @@ def _insert_aggregates_into_details_table(
)
agg_details_df_list.append(agg_details_rule_df)
else:
logger.warning("Aggregate Details Rules are empty")
logger.info(
f"Aggregate rule reconciliation is successful."
f" No details to store."
f" Rule: {agg_output.rule.column_from_rule}"
if agg_output.rule
else ""
)

if agg_details_df_list:
agg_details_table_df = self._union_dataframes(agg_details_df_list)
Expand Down
14 changes: 5 additions & 9 deletions src/databricks/labs/lakebridge/reconcile/reconciliation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
from databricks.labs.lakebridge.reconcile.recon_config import (
Schema,
Table,
AggregateQueryRules,
SamplingOptions,
)
from databricks.labs.lakebridge.reconcile.recon_output_config import (
Expand Down Expand Up @@ -212,21 +211,18 @@ def _get_reconcile_aggregate_output(
#3, MAX, COL3,
"""

src_query_builder = AggregateQueryBuilder(
# build Aggregate queries for source, There could be one
# or more queries per table based on the group by columns
src_agg_queries = AggregateQueryBuilder(
table_conf,
src_schema,
"source",
self._source_engine,
self._source,
)

# build Aggregate queries for source,
src_agg_queries: list[AggregateQueryRules] = src_query_builder.build_queries()

# There could be one or more queries per table based on the group by columns
).build_queries()

# build Aggregate queries for target(Databricks),
tgt_agg_queries: list[AggregateQueryRules] = AggregateQueryBuilder(
tgt_agg_queries = AggregateQueryBuilder(
table_conf,
tgt_schema,
"target",
Expand Down
Loading