Skip to content

Conversation

@goanpeca
Copy link
Collaborator

@goanpeca goanpeca commented Oct 16, 2025

Needed for fixing

datalayer/vscode-datalayer#9

Also fixes CI checks!

@goanpeca goanpeca self-assigned this Oct 16, 2025
@goanpeca goanpeca marked this pull request as ready for review October 16, 2025 21:16
@goanpeca goanpeca requested review from Copilot and echarles October 16, 2025 21:16
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the adapter to handle undo/redo actions and fixes CI checks. The key changes include adding undo/redo methods to the notebook adapter, cleaning up ESLint configuration, and removing deprecated CI workflows.

  • Added undo/redo functionality to the notebook adapter and state management
  • Cleaned up ESLint configuration and fixed linting issues across multiple files
  • Removed outdated CI workflows and updated configuration files

Reviewed Changes

Copilot reviewed 37 out of 39 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
packages/react/src/components/notebook/Notebook2Adapter.ts Added undo/redo methods to the adapter class
packages/react/src/components/notebook/Notebook2State.ts Added undo/redo actions to the state management
packages/react/src/jupyter/JupyterConfig.ts Added resetJupyterConfig function for configuration cleanup
packages/react/eslint.config.js Updated ESLint configuration with improved TypeScript and file handling
Multiple lexical files Fixed code formatting and removed unnecessary ESLint disable comments
CI workflow files Removed deprecated VSCode-specific CI workflows

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Member

@echarles echarles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thx @goanpeca

@echarles echarles merged commit e57291d into datalayer:main Oct 17, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants