-
-
Notifications
You must be signed in to change notification settings - Fork 61
Update adapter to handle undo/redo actions #415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
93a752b to
34a47a6
Compare
83b5ba0 to
827ebad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the adapter to handle undo/redo actions and fixes CI checks. The key changes include adding undo/redo methods to the notebook adapter, cleaning up ESLint configuration, and removing deprecated CI workflows.
- Added undo/redo functionality to the notebook adapter and state management
- Cleaned up ESLint configuration and fixed linting issues across multiple files
- Removed outdated CI workflows and updated configuration files
Reviewed Changes
Copilot reviewed 37 out of 39 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/react/src/components/notebook/Notebook2Adapter.ts | Added undo/redo methods to the adapter class |
| packages/react/src/components/notebook/Notebook2State.ts | Added undo/redo actions to the state management |
| packages/react/src/jupyter/JupyterConfig.ts | Added resetJupyterConfig function for configuration cleanup |
| packages/react/eslint.config.js | Updated ESLint configuration with improved TypeScript and file handling |
| Multiple lexical files | Fixed code formatting and removed unnecessary ESLint disable comments |
| CI workflow files | Removed deprecated VSCode-specific CI workflows |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thx @goanpeca
Needed for fixing
datalayer/vscode-datalayer#9
Also fixes CI checks!