Handle default of None properly for cumulative_type_params
#371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbt-core parses YAML differently than DSI. There, the YAML dict for a metric ends up with if that key is empty. Then when we call type_params.get(cumulative_type_params, {}), the result is None because the key does exist in the dict. This results in a key error when we finally call .get(grain_to_date). Thus, we must set the default value outside of .get().
courtneyholcomb
requested review from
QMalcolm,
graciegoheen and
a team
as code owners
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
WilliamDee
approved these changes
Dec 3, 2024
| @@ -209,8 +209,8 @@ def parse_obj(cls, input: Any) -> PydanticMetric: | |||
| data = deepcopy(input) | |||
|
|
|||
| # Ensure grain_to_date is lowercased | |||
| type_params = data.get("type_params", {}) | |||
| grain_to_date = type_params.get("cumulative_type_params", {}).get("grain_to_date") | |||
| type_params = data.get("type_params") or {} | |||
theyostalservice
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dbt-core parses YAML differently than DSI. There, the YAML dict for a metric ends up with if that key is empty. Then when we call type_params.get(cumulative_type_params, {}), the result is None because the key does exist in the dict. This results in a key error when we finally call .get(grain_to_date). Thus, we must set the default value outside of .get().
Resolves #
Description
Checklist
changie newto create a changelog entry