Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle default of None properly for cumulative_type_params #371

Merged
merged 2 commits into from
Dec 3, 2024

Commits on Dec 3, 2024

  1. Handle default of None properly for cumulative_type_params

    dbt-core parses YAML differently than DSI. There, the YAML dict for a metric ends up with  if that key is empty. Then when we call type_params.get(cumulative_type_params, {}), the result is None because the key does exist in the dict. This results in a key error when we finally call .get(grain_to_date). Thus, we must set the default value outside of .get().
    courtneyholcomb committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    616a74a View commit details
    Browse the repository at this point in the history
  2. Bump version

    courtneyholcomb committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    ae71d57 View commit details
    Browse the repository at this point in the history