Add logic to enable iceberg incremental tables. #1190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-snowflake contributing guide. |
VersusFacit
commented
Sep 24, 2024
VersusFacit
commented
Sep 24, 2024
mikealfare
reviewed
Sep 24, 2024
VersusFacit
commented
Sep 26, 2024
VersusFacit
force-pushed
the
ADAP-321/add_iceberg_incremental_models
branch
from
6978136
to
0e6c1c6
Compare
VersusFacit
commented
Sep 26, 2024
VersusFacit
commented
Sep 26, 2024
mikealfare
reviewed
Sep 26, 2024
mikealfare
approved these changes
Sep 26, 2024
|
I verified that the new configuration of the replacement type tests is replacing an iceberg table with an incremental iceberg table and vice versa, even after we changed the test case logic. |
| @@ -58,12 +58,21 @@ | |||
|
|
|||
| {% materialization incremental, adapter='snowflake', supported_languages=['sql', 'python'] -%} | |||
|
|
|||
| {% set original_query_tag = set_query_tag() %} | |||
There was a problem hiding this comment.
Hi @VersusFacit, I noticed that the query tags for incremental models are not applied anymore.
Why did you remove this line?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves: #321
Problem
Add incremental models
Solution
Leverage existing code abstractions.
Checklist