-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logic to enable iceberg incremental tables. #1190
Merged
Merged
Changes from 2 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
b424333
Add logic to enable iceberg incremental tables.
VersusFacit d1755a6
Add changelog.
VersusFacit 9cd00f4
Standardize existing_relation as name of existing model.
VersusFacit 30842b3
Improve error message for table formats.
VersusFacit 748a783
Update error message and add round of tests.
VersusFacit 0204690
Add more comprehensive tests for before/after.
VersusFacit 8983a69
Update identifier param in incremental materialization.
VersusFacit 1eedd20
Update test name.
VersusFacit 6df03c8
tabs
VersusFacit 47f6595
Import Mike's revision on the relation type change test.
VersusFacit 0c70786
Try adding iceberg incremental model scenarios.
VersusFacit ae36bf3
Disable dynamic tests.
VersusFacit 623a005
Refine booleans for more restricting when incremental models are built.
VersusFacit 0e6c1c6
Update tests to reflect realities on the database.
VersusFacit da9fb79
Add additional metadata.
VersusFacit 20fa7dd
Update boolean logic for faster runs overall.
VersusFacit e74aca2
Last bit of cleanup per code review
VersusFacit 67a94e8
Syntax error from lack of iterable.
VersusFacit File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
kind: Features | ||
body: Add Iceberg format Incremental Models | ||
time: 2024-09-23T20:32:04.783741-07:00 | ||
custom: | ||
Author: versusfacit | ||
Issue: "321" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @VersusFacit, I noticed that the query tags for incremental models are not applied anymore.
Why did you remove this line?