Fix User Application Role Connection endpoints#125
Merged
Exanlv merged 2 commits intodc-Ragnarok:masterfrom Sep 2, 2025
Merged
Fix User Application Role Connection endpoints#125Exanlv merged 2 commits intodc-Ragnarok:masterfrom
Exanlv merged 2 commits intodc-Ragnarok:masterfrom
Conversation
* Added applicationId paramter and binding
* Added required applicationId paramater and set bind * Changed metadata type to optional object (as noted in Discord docs)
Exanlv
reviewed
Aug 31, 2025
| public ?string $platform_name; | ||
| public ?string $platform_username; | ||
| public ApplicationRoleConnectionMetadata $metadata; | ||
| public ?object $metadata; |
Collaborator
There was a problem hiding this comment.
What's the reason for this change?
Contributor
Author
There was a problem hiding this comment.
Metadata is empty with ApplicationRoleConnectionMetadata because the response from the API that is for the user isn't of that format.
It returns an object with the metadata key names and their values.
String=>String|Int
The other method getRecords() does use ApplicationRoleConnectionMetadata but not this one.
Collaborator
There was a problem hiding this comment.
I'll fix the mapping in a later release
Exanlv
approved these changes
Sep 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The user and application role connection needs to have a bind for ":applicationId" so added that, and change mapping to be correct for the data that is returned.