Skip to content

Fix User Application Role Connection endpoints #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Exanlv merged 2 commits into from
Sep 2, 2025
Merged

Fix User Application Role Connection endpoints #125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4438425
Fixed Application Role Connection endpoints
PhaxeNor Aug 30, 2025
9d37b62
Fixed User Role Connection endpoints
PhaxeNor Aug 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Parts/ApplicationRoleConnection.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,5 @@ class ApplicationRoleConnection
{
public ?string $platform_name;
public ?string $platform_username;
public ApplicationRoleConnectionMetadata $metadata;
public ?object $metadata;
Copy link
Collaborator

@Exanlv Exanlv Aug 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason for this change?

Copy link
Contributor Author

@PhaxeNor PhaxeNor Aug 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Metadata is empty with ApplicationRoleConnectionMetadata because the response from the API that is for the user isn't of that format.

It returns an object with the metadata key names and their values.

String=>String|Int

The other method getRecords() does use ApplicationRoleConnectionMetadata but not this one.

Copy link
Collaborator

@Exanlv Exanlv Sep 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll fix the mapping in a later release

}
18 changes: 12 additions & 6 deletions src/Rest/ApplicationRoleConnectionMetadata.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,14 @@ class ApplicationRoleConnectionMetadata extends HttpResource
*
* @return PromiseInterface<\Ragnarok\Fenrir\Parts\ApplicationRoleConnectionMetadata>
*/
public function getRecords(): PromiseInterface
public function getRecords(string $applicationId): PromiseInterface
{
return $this->mapPromise(
return $this->mapArrayPromise(
$this->http->get(
Endpoint::APPLICATION_ROLE_CONNECTION_METADATA,
Endpoint::bind(
Endpoint::APPLICATION_ROLE_CONNECTION_METADATA,
$applicationId
)
),
PartsApplicationRoleConnectionMetadata::class,
);
Expand All @@ -33,11 +36,14 @@ public function getRecords(): PromiseInterface
*
* @return PromiseInterface<\Ragnarok\Fenrir\Parts\ApplicationRoleConnectionMetadata>
*/
public function updateRecords(array $params): PromiseInterface
public function updateRecords(string $applicationId, array $params): PromiseInterface
{
return $this->mapPromise(
return $this->mapArrayPromise(
$this->http->put(
Endpoint::APPLICATION_ROLE_CONNECTION_METADATA,
Endpoint::bind(
Endpoint::APPLICATION_ROLE_CONNECTION_METADATA,
$applicationId
),
$params,
),
PartsApplicationRoleConnectionMetadata::class,
Expand Down
14 changes: 10 additions & 4 deletions src/Rest/User.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,11 +189,14 @@ public function getCurrentUserConnections(): PromiseInterface
*
* @return PromiseInterface<\Ragnarok\Fenrir\Parts\ApplicationRoleConnection>
*/
public function getCurrentUserApplicationRoleConnection(): PromiseInterface
public function getCurrentUserApplicationRoleConnection(string $applicationId): PromiseInterface
{
return $this->mapPromise(
$this->http->get(
Endpoint::USER_CURRENT_APPLICATION_ROLE_CONNECTION,
Endpoint::bind(
Endpoint::USER_CURRENT_APPLICATION_ROLE_CONNECTION,
$applicationId
),
),
ApplicationRoleConnection::class,
);
Expand All @@ -204,11 +207,14 @@ public function getCurrentUserApplicationRoleConnection(): PromiseInterface
*
* @return PromiseInterface<\Ragnarok\Fenrir\Parts\ApplicationRoleConnection>
*/
public function updateCurrentUserApplicationRoleConnection(array $params): PromiseInterface
public function updateCurrentUserApplicationRoleConnection(string $applicationId, array $params): PromiseInterface
{
return $this->mapPromise(
$this->http->put(
Endpoint::USER_CURRENT_APPLICATION_ROLE_CONNECTION,
Endpoint::bind(
Endpoint::USER_CURRENT_APPLICATION_ROLE_CONNECTION,
$applicationId
),
$params
),
ApplicationRoleConnection::class,
Expand Down