Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(release): build binary for ARM/aarch64 Linux in release workflow #328

Merged
merged 1 commit into from
Apr 4, 2022
Merged

feat(release): build binary for ARM/aarch64 Linux in release workflow #328

merged 1 commit into from
Apr 4, 2022

Conversation

VishnuJin
Copy link
Contributor

@VishnuJin VishnuJin commented Mar 30, 2022 •
edited
Loading

fixes #325

This PR adds step to build binary for Linux aarch64 to Bindle releases

@VishnuJin VishnuJin marked this pull request as draft March 30, 2022 15:18
@VishnuJin VishnuJin force-pushed the feat-add-linux-aarch-binary branch 2 times, most recently from fd15c4b to a99664d Compare March 30, 2022 18:19
@VishnuJin
Copy link
Contributor Author

currently facing issue with the compilation of ring in aarch64

My Build URL - https://github.com/VishnuJin/bindle/runs/5759376008?check_suite_focus=true

error: failed to run custom build command for `ring v0.16.20`

@VishnuJin VishnuJin force-pushed the feat-add-linux-aarch-binary branch 2 times, most recently from 7e89087 to 0104838 Compare March 31, 2022 15:21
@VishnuJin
Copy link
Contributor Author

currently facing issue with the compilation of ring in aarch64

My Build URL - https://github.com/VishnuJin/bindle/runs/5759376008?check_suite_focus=true

error: failed to run custom build command for `ring v0.16.20`

this is now resolved

@VishnuJin
Copy link
Contributor Author

ran in to another issue, this one with hyper

https://github.com/VishnuJin/bindle/runs/5774669863?check_suite_focus=true

error adding symbols: file in wrong format
[650](https://github.com/VishnuJin/bindle/runs/5774669863?check_suite_focus=true#step:12:650)
          collect2: error: ld returned 1 exit status
[651](https://github.com/VishnuJin/bindle/runs/5774669863?check_suite_focus=true#step:12:651)
          
[652](https://github.com/VishnuJin/bindle/runs/5774669863?check_suite_focus=true#step:12:652)

[653](https://github.com/VishnuJin/bindle/runs/5774669863?check_suite_focus=true#step:12:653)
error: could not compile `hyper` due to previous error
[653](https://github.com/VishnuJin/bindle/runs/5774669863?check_suite_focus=true#step:12:653)
Error: The process '/home/runner/.cargo/bin/cargo' failed with exit code 101

@VishnuJin VishnuJin force-pushed the feat-add-linux-aarch-binary branch from 82798d6 to c2772da Compare March 31, 2022 18:12
@VishnuJin
Copy link
Contributor Author

ran in to another issue, this one with hyper

https://github.com/VishnuJin/bindle/runs/5774669863?check_suite_focus=true

error adding symbols: file in wrong format
[650](https://github.com/VishnuJin/bindle/runs/5774669863?check_suite_focus=true#step:12:650)
          collect2: error: ld returned 1 exit status
[651](https://github.com/VishnuJin/bindle/runs/5774669863?check_suite_focus=true#step:12:651)
          
[652](https://github.com/VishnuJin/bindle/runs/5774669863?check_suite_focus=true#step:12:652)

[653](https://github.com/VishnuJin/bindle/runs/5774669863?check_suite_focus=true#step:12:653)
error: could not compile `hyper` due to previous error
[653](https://github.com/VishnuJin/bindle/runs/5774669863?check_suite_focus=true#step:12:653)
Error: The process '/home/runner/.cargo/bin/cargo' failed with exit code 101

resolved by adding linker path in cargo config

@VishnuJin
Copy link
Contributor Author

VishnuJin commented Mar 31, 2022 •
edited
Loading

@radu-matei @thomastaylor312
Success build for Linux aarch64 in my repo - https://github.com/VishnuJin/bindle/runs/5775720248?check_suite_focus=true

@VishnuJin VishnuJin marked this pull request as ready for review March 31, 2022 18:15
@VishnuJin VishnuJin changed the title feat(release): add build support for aarch64 linux binary feat(release): build binary for ARM/aarch64 Linux in release workflow Mar 31, 2022
vdice
vdice reviewed Apr 1, 2022
View reviewed changes
Copy link
Member

@vdice vdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks great to me, though, if we don't want to add/maintain the .cargo/config file in this repo's source, we could echo both lines into that location in the same 'setup for cross-compile builds' step for linux-aarch64, just-in-time.

@VishnuJin
Copy link
Contributor Author

@vdice hmm but just wondering in Krustlet we have .cargo folder in the repo so I thought its fine for bindle as well ?

@vdice
Copy link
Member

vdice commented Apr 1, 2022

@VishnuJin Ok, it's probably fine -- and could be useful when/if other targets are added as well. 👍

@VishnuJin VishnuJin requested a review from vdice April 1, 2022 18:06
vdice
vdice approved these changes Apr 1, 2022
View reviewed changes
Copy link
Member

@vdice vdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding @VishnuJin! LGTM from me. Ping @thomastaylor312 or @radu-matei for final approval.

thomastaylor312
thomastaylor312 approved these changes Apr 4, 2022
View reviewed changes
Copy link
Contributor

@thomastaylor312 thomastaylor312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for figuring this out @VishnuJin@

@vdice Feel free to merge when you are ready

@vdice vdice merged commit f7e31cc into deislabs:main Apr 4, 2022
@vdice
Copy link
Member

vdice commented Apr 4, 2022

Thank you @VishnuJin !

vdice pushed a commit to vdice/bindle that referenced this pull request Dec 8, 2022
@VishnuJin @vdice
add build support for aarch64 linux binary (deislabs#328)
e372ff7
@vdice vdice mentioned this pull request Dec 8, 2022
Merged
vdice added a commit that referenced this pull request Dec 13, 2022
@vdice @VishnuJin @bacongobbler
chore(release/0.8): cherry-pick CI features/fixes (#359)
d80ba6f 
* add build support for aarch64 linux binary (#328)

* Bump azure-blob-storage-upload to v2.0.1

Signed-off-by: Matthew Fisher <[email protected]>

* fix(deny.toml): add Unicode-DFS-2016 to allowed licenses

Signed-off-by: Vaughn Dice <[email protected]>

Signed-off-by: Matthew Fisher <[email protected]>
Signed-off-by: Vaughn Dice <[email protected]>
Co-authored-by: VishnuJin <[email protected]>
Co-authored-by: Matthew Fisher <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdice vdice vdice approved these changes

@thomastaylor312 thomastaylor312 thomastaylor312 approved these changes

@technosophos technosophos Awaiting requested review from technosophos technosophos is a code owner

@radu-matei radu-matei Awaiting requested review from radu-matei radu-matei is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Binary for Linux ARM64
3 participants
@VishnuJin @vdice @thomastaylor312