Skip to content
This repository has been archived by the owner on Oct 28, 2024. It is now read-only.

Remove HIPPOFACTS logic and bindle client #121

Merged
merged 4 commits into from
Apr 13, 2022

Conversation

bacongobbler
Copy link
Contributor

As of Hippo 0.6, the wagi runtime has been replaced with the Spin
runtime. The Spin CLI plans to implement commands like spin deploy
which will be used to package and distribute a Spin application to
Hippo.[1]

This change reduces the Hippo CLI to the bare minimum. The new role of
the Hippo CLI is to implement all of the endpoints available through the
hippo-openapi project. This is to help serve as a reference point for
those looking to write their own Hippo clients against the
hippo-openapi[2] project (like Spin), and it could also serve as a
useful administrator tool looking to inspect and/or understand the Hippo
API.

Also changed in this PR:

  • hippo auth commands have been moved one level lower:
    • hippo auth login -> hippo login
    • hippo auth logout -> hippo logout
    • hippo auth register -> hippo register
    • hippo auth whoami -> hippo whoami

[1]: fermyon/spin#304
[2]: https://github.com/fermyon/hippo-openapi

Signed-off-by: Matthew Fisher [email protected]

@bacongobbler
Copy link
Contributor Author

bacongobbler commented Apr 7, 2022

TODO:

  • update README with examples

@bacongobbler bacongobbler force-pushed the remove-bindle-hippofacts branch from 1cfd592 to 2350c96 Compare April 7, 2022 16:04
@bacongobbler
Copy link
Contributor Author

After some feedback from @michelleN, it might be worth keeping around some of the hippo bindle commands, but remove the HIPPOFACTS logic for now. At some point in the future, we could discuss what stuff should be present in a HIPPOFACTS file vs a spin.toml file. For example, the application name, Bindle ID, what channels to create, the domain names and revision selection strategies, etc.

@bacongobbler
Copy link
Contributor Author

Hmm... I don't see how we can accomplish retaining the bindle commands without ripping out the HIPPOFACTS logic. The two are very tightly coupled... Even hippo bindle prepare relies on the HIPPOFACTS file.

I'm going to opt to remove it. Let's revisit the WAGI/HIPPOFACTS story with spin.

As of Hippo 0.6, the wagi runtime has been replaced with the Spin
runtime. The Spin CLI plans to implement commands like `spin deploy`
which will be used to package and distribute a Spin application to
Hippo.[1]

This change reduces the Hippo CLI to the bare minimum. The new role of
the Hippo CLI is to implement all of the endpoints available through the
hippo-openapi project. This is to help serve as a reference point for
those looking to write their own Hippo clients against the
hippo-openapi[2] project (like Spin), and it could also serve as a
useful administrator tool looking to inspect and/or understand the Hippo
API.

[1]: fermyon/spin#304
[2]: https://github.com/fermyon/hippo-openapi

Signed-off-by: Matthew Fisher <[email protected]>
@bacongobbler bacongobbler force-pushed the remove-bindle-hippofacts branch from 2350c96 to abe3d1e Compare April 13, 2022 17:30
Signed-off-by: Matthew Fisher <[email protected]>
Signed-off-by: Matthew Fisher <[email protected]>
@bacongobbler bacongobbler force-pushed the remove-bindle-hippofacts branch from e781ead to ed7ef4e Compare April 13, 2022 17:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant