Skip to content
This repository has been archived by the owner on Feb 22, 2024. It is now read-only.

Fix integration tests and Added wildcard to allow all domains #91

Merged
merged 5 commits into from
May 9, 2022
Merged

Fix integration tests and Added wildcard to allow all domains #91

merged 5 commits into from
May 9, 2022

Conversation

Mossaka
Copy link
Member

@Mossaka Mossaka commented May 2, 2022

  • fixed integration tests
  • added wildcard
  • added unit tests

@Mossaka
fixed integration tests
a449bce 
Signed-off-by: Jiaxiao Zhou <[email protected]>
@Mossaka
added wildcard
b1c09ad 
Signed-off-by: Jiaxiao Zhou <[email protected]>
@Mossaka
added unit tests
c093723 
Signed-off-by: Jiaxiao Zhou <[email protected]>
This was referenced May 2, 2022
Merged
Closed
@radu-matei
Copy link
Member

Could you please keep the useful commits here?

Thanks a lot!

@Mossaka
Copy link
Member Author

Mossaka commented May 2, 2022

Could you please keep the useful commits here?

Thanks a lot!

Do you mean by doing just a merge commit, instead of squash commit?

@lann
Copy link

lann commented May 3, 2022 •
edited
Loading

Might want to be more cautious here: fermyon/spin#421 (comment)

(I'm not a maintainer on this project, but I would block merge pending this discussion.)

@lann
Copy link

lann commented May 6, 2022

Thanks!

@Mossaka Mossaka merged commit 9a143fa into deislabs:main May 9, 2022
@Mossaka Mossaka deleted the jiazho/host_wildcard branch May 9, 2022 18:25
@radu-matei radu-matei mentioned this pull request May 18, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@radu-matei radu-matei radu-matei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mossaka @radu-matei @lann