feat: Implement a wildcard in http allowed_domains to allow all domains #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jiaxiao Zhou <[email protected]>
Signed-off-by: Jiaxiao Zhou <[email protected]>
lann
reviewed
May 3, 2022
lann
requested changes
May 3, 2022
Signed-off-by: Jiaxiao Zhou <[email protected]>
Signed-off-by: Jiaxiao Zhou <[email protected]>
Signed-off-by: Jiaxiao Zhou <[email protected]>
Signed-off-by: Jiaxiao Zhou <[email protected]>
Signed-off-by: Jiaxiao Zhou <[email protected]>
Signed-off-by: Jiaxiao Zhou <[email protected]>
lann
requested changes
May 10, 2022
Signed-off-by: Jiaxiao Zhou <[email protected]>
lann
approved these changes
May 11, 2022
danbugs
pushed a commit
to danbugs/spin
that referenced
this pull request
May 12, 2022
…ns (fermyon#422) * added wildcard host and a rust outbound http example * updated outbound http upstream Signed-off-by: Jiaxiao Zhou <[email protected]> Signed-off-by: danbugs <[email protected]>
danbugs
pushed a commit
to danbugs/spin
that referenced
this pull request
May 12, 2022
…ns (fermyon#422) * added wildcard host and a rust outbound http example * updated outbound http upstream Signed-off-by: Jiaxiao Zhou <[email protected]>
danbugs
pushed a commit
to danbugs/spin
that referenced
this pull request
May 12, 2022
…ns (fermyon#422) * added wildcard host and a rust outbound http example * updated outbound http upstream Signed-off-by: Jiaxiao Zhou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue #421 .
It does
"*"option toallowed_http_hostsin HTTP component.Note: this PR has a dependency on deislabs/wasi-experimental-http#91.
Once the upstream PR is merged, this PR will go off-draft.