fix: close iroh endpoint when I/O is stopped #6264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
link2xt
force-pushed
the
link2xt/iroh-stop-io
branch
2 times, most recently
from
143e177 to
509cce5
Compare
iequidoo
reviewed
Nov 26, 2024
link2xt
force-pushed
the
link2xt/iroh-stop-io
branch
from
509cce5 to
6087bb2
Compare
link2xt
force-pushed
the
link2xt/iroh-stop-io
branch
2 times, most recently
from
f918ecb to
f1f2aac
Compare
iequidoo
approved these changes
Nov 27, 2024
| alice | ||
| .get_or_try_init_peer_channel() | ||
| .await | ||
| .unwrap() |
There was a problem hiding this comment.
Minor, but i'd return Result from tests to get rid of unwrap() everywhere, it really eats much screen space :)
link2xt
force-pushed
the
link2xt/iroh-stop-io
branch
from
3f2c8b9 to
0e0d312
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.