Offer to copy non-HTTP links to the clipboard instead of trying to open them #3388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simon-Laux
requested review from
ralphtheninja,
farooqkz,
link2xt and
achou11
link2xt
reviewed
Sep 7, 2023
src/renderer/runtime.ts
Outdated
| @@ -493,8 +493,12 @@ class Electron implements Runtime { | |||
| openLink(link: string): void { | |||
| if (link.startsWith('mailto:')) { | |||
| processOpenQrUrl(link) | |||
| } else { | |||
| } else if (link.startsWith('http')) { | |||
There was a problem hiding this comment.
I would rather explicitly check for "http://" or "https://" prefix with ||, who knows if some app decides to register httpx scheme.
ralphtheninja
approved these changes
Sep 7, 2023
Simon-Laux
deleted the
simon/copy-links-with-custom-schemes-to-clipboard
branch
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.