-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Most Recent Webxdc apps but make it a widget #2418
base: main
Are you sure you want to change the base?
Conversation
8f46a71
to
4c96285
Compare
65f64bc
to
29360bd
Compare
6ba0d55
to
da5599a
Compare
y u no github issues and milestones and such :D # Conflicts: # CHANGELOG.md
fab2718
to
bcb38e0
Compare
DcWebxdcWidget/DcWebxdcWidget.swift
Outdated
for accountId in dcAccounts.getAll() { | ||
let dcContext = dcAccounts.get(id: accountId) | ||
if dcContext.isOpen() == false { | ||
do { | ||
let secret = try KeychainManager.getAccountSecret(accountID: accountId) | ||
_ = dcContext.open(passphrase: secret) | ||
} catch { | ||
debugPrint("Couldn't open \(error.localizedDescription)") | ||
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this can be removed, encrypted accounts are deprecated at #2011, also in the newer DcNotificationService we do not care for encrypted accounts
for accountId in dcAccounts.getAll() { | |
let dcContext = dcAccounts.get(id: accountId) | |
if dcContext.isOpen() == false { | |
do { | |
let secret = try KeychainManager.getAccountSecret(accountID: accountId) | |
_ = dcContext.open(passphrase: secret) | |
} catch { | |
debugPrint("Couldn't open \(error.localizedDescription)") | |
} | |
} | |
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, that's good to know, thank you!
I basically just copied this from AppDelegate.continueDidFinishLaunchingWithOptions
. Should we remove it there as well?
DcWebxdcWidget/Assets.xcassets/AppIcon.appiconset/Contents.json
Outdated
Show resolved
Hide resolved
Co-authored-by: bjoern <[email protected]>
b2c2b1a
to
a526b41
Compare
This PR adds a Widget to Deltachat. The widget shows the most recent Webxdc-apps on the Homescreen so that users can open them right away from the Homescreen. It comes in two flavours/sizes:
They look like this:
When users tap on an icon, the selected app opens right away in the right chat. The list gets updated every 15 minutes.
When adding them to the Homescreen, users see this:
The icons for this placeholder come from various Webxdc-app-repos.
Also: This PR makes CI use Xcode 16. And closes #2406
Sidenote: Widgets are more fun on an actual device than in the Simulator.
Sidenote: Widget is not localized yet.