fix: remove dialog close button warning for prop-based dialogs#2228
Merged
frankensteinke merged 2 commits intodevelopfrom Feb 6, 2026
Merged
fix: remove dialog close button warning for prop-based dialogs#2228frankensteinke merged 2 commits intodevelopfrom
frankensteinke merged 2 commits intodevelopfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a warning that was incorrectly appearing for prop-based dialogs when forceAction is set to true. The warning in DialogCloseButton is intended to alert developers when they manually include a close button in a custom header while also setting forceAction to true, but it was triggering for prop-based dialogs where the close button is automatically rendered.
Changes:
- Conditionally render the
DialogCloseButtonbased on theforceActionprop to prevent the warning from appearing in prop-based dialogs
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
frankensteinke
changed the title
chornonoh-vova
requested changes
Feb 4, 2026
anastasialanz
approved these changes
Feb 5, 2026
chornonoh-vova
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: https://github.com/dequelabs/axe-extension/issues/7457
<DialogCloseButton>will emit a warning whenever a prop-based modal is created withforceActionset to true. The warning is still helpful if the user creates a compound header and doesn't include a close button, but this update will get rid of the warning in all other cases.