Skip to content

fix: remove dialog close button warning for prop-based dialogs #2228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frankensteinke merged 2 commits into from
Feb 6, 2026
Merged

fix: remove dialog close button warning for prop-based dialogs #2228

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f67d5dd
fix: dialog close button warning shows up for prop-based dialogs
frankensteinke Feb 4, 2026
ac35aa9
Add test for change
frankensteinke Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react/src/components/Dialog/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ const Dialog = forwardRef<HTMLDivElement, DialogProps>(
? heading.text
: heading}
</DialogHeading>
<DialogCloseButton />
{!forceAction ? <DialogCloseButton /> : null}
</DialogHeader>
) : null}
{children}
Expand Down