Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: all issues #102

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix: all issues #102

wants to merge 5 commits into from

Conversation

ilyuka
Copy link

@ilyuka ilyuka commented Jul 19, 2023

No description provided.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on formatting the HTML code! It looks much cleaner now.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, it's 'Prettier'

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on the changes! The border color change from 'purple' to 'lightblue' in line 20 really improves the look of the table. The background color addition in line 40 also adds a nice touch. Just one small suggestion: in lines 22-23, it would be better to keep the 'padding' property on the same line for readability.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got you, maybe i'll change Prettier config

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants