-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: all issues #102
Open
ilyuka
wants to merge
5
commits into
developer-job-simulation:main
Choose a base branch
from
ilyuka:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix: all issues #102
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
67aa7ce
fix: table not pretty
ilyuka 3dac8dc
fix: revenue numbers in non-human-readable format
ilyuka c67b895
fix: "created at" date in non-human-readable format
ilyuka 436031b
fix: company names are missing
ilyuka 9721dfb
fix: incorrect value of revenue in json
ilyuka File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,28 +1,28 @@ | ||
| { | ||
| "companies": [ | ||
| { | ||
| "id": 1, | ||
| "name": "Fusion LLC", | ||
| "status": "Qualified Lead", | ||
| "created_at": "2021-04-27T03:41:56Z", | ||
| "account_executive": "Abigayle Gibson", | ||
| "revenue_ytd": 17000000 | ||
| }, | ||
| { | ||
| "id": 2, | ||
| "name": "Techopolis Ltd.", | ||
| "status": "Paying Customer", | ||
| "created_at": "2021-11-23T08:45:56Z", | ||
| "account_executive": "Joe Bond", | ||
| "revenue_ytd": 7375294 | ||
| }, | ||
| { | ||
| "id": 3, | ||
| "name": "Code learning LLC", | ||
| "status": "Lead", | ||
| "created_at": "2022-04-15T12:45:56Z", | ||
| "account_executive": "Annie Ibarra", | ||
| "revenue_ytd": 100000 | ||
| } | ||
| ] | ||
| } | ||
| "companies": [ | ||
| { | ||
| "id": 1, | ||
| "name": "Fusion LLC", | ||
| "status": "Qualified Lead", | ||
| "created_at": "2021-04-27T03:41:56Z", | ||
| "account_executive": "Abigayle Gibson", | ||
| "revenue_ytd": 17000000 | ||
| }, | ||
| { | ||
| "id": 2, | ||
| "name": "Techopolis Ltd.", | ||
| "status": "Paying Customer", | ||
| "created_at": "2021-11-23T08:45:56Z", | ||
| "account_executive": "Joe Bond", | ||
| "revenue_ytd": 7375294 | ||
| }, | ||
| { | ||
| "id": 3, | ||
| "name": "Code learning LLC", | ||
| "status": "Lead", | ||
| "created_at": "2022-04-15T12:45:56Z", | ||
| "account_executive": "Annie Ibarra", | ||
| "revenue_ytd": 100000 | ||
| } | ||
| ] | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,14 +1,14 @@ | ||
| <!DOCTYPE html> | ||
| <html lang="en"> | ||
| <head> | ||
| <meta charset="UTF-8"> | ||
| <title>Customers</title> | ||
| <link rel="stylesheet" href="styles.css"> | ||
| </head> | ||
| <body> | ||
| <div> | ||
| <h1>My Customers</h1> | ||
| <script type="text/javascript" src="dist/bundle.js"></script> | ||
| </div> | ||
| </body> | ||
| </html> | ||
| <head> | ||
| <meta charset="UTF-8" /> | ||
| <title>Customers</title> | ||
| <link rel="stylesheet" href="styles.css" /> | ||
| </head> | ||
| <body> | ||
| <div> | ||
| <h1>My Customers</h1> | ||
| <script type="text/javascript" src="dist/bundle.js"></script> | ||
| </div> | ||
| </body> | ||
| </html> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on formatting the HTML code! It looks much cleaner now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, it's 'Prettier'