Issue 245 #274
Open
Issue 245 #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DominMFD
requested changes
Jun 24, 2024
Alecell
requested changes
Jun 24, 2024
Comment on lines
156
to
160
| if (validPassword) $passwordErrorMessage.classList.remove('show-error'); | ||
| if (validNewPassword) | ||
| $newPasswordErrorMessage.classList.remove('show-error'); | ||
| if (validConfirmPassword) | ||
| $confirmPasswordErrorMessage.classList.remove('show-error'); |
There was a problem hiding this comment.
A remoção do erro idealmente deveria acontecer no ato de digitar, no caso, se a pessoa alterar algum dos campos com erro ja remover os erros, remover apenas quando poder enviar da uma impressão de que a pessoa teria que clicar no botao de enviar mesmo com os campos exibindo erro, talvez isso não seja ideal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #245
Feature
Adiciona o componente de alteração de senha
Visual evidences
Checklist
Additional info
Está pendendo o botão de visualizar senha