Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 245 #274
base: main
Are you sure you want to change the base?
Issue 245 #274
Changes from 2 commits
47d0d62
28eb2c6
9772932
d8e78b8
ff51ad8
7d05469
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Talvez não seja ideal validar os 3 campos juntos, acredito que essa função poderia receber um
data-select
como parametro, ai pegar apenas aquele campo e entao valida-loThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A remoção do erro idealmente deveria acontecer no ato de digitar, no caso, se a pessoa alterar algum dos campos com erro ja remover os erros, remover apenas quando poder enviar da uma impressão de que a pessoa teria que clicar no botao de enviar mesmo com os campos exibindo erro, talvez isso não seja ideal