Use generated Codable implementation for TypeDescription #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8 +/- ##
==========================================
- Coverage 97.78% 97.66% -0.12%
==========================================
Files 37 37
Lines 7804 7322 -482
==========================================
- Hits 7631 7151 -480
+ Misses 173 171 -2
|
|
Merging this, but will wait a bit before releasing since there are going to be a few breaking changes landing. If folk have feedback post-merge please leave a comment! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back when we first wrote
TypeDescriptiona few years back, Swift was not capable of generating theCodableimplementation for indirect enums with associated values. Now it is.Instead of continuing to maintain and test a manual
Codableimplementation, let's rely on Apple's implementation. A nice bonus is that Apple's implementation is more compact than our implementation, which will likely improve encoding/decoding speed for folk utilizing persistence.This is a breaking change.