-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(framework): target netstandard2.0 and net8.0 #90
base: main
Are you sure you want to change the base?
Conversation
Hi, and thank you for your interest in the project! |
The truth is, compiler directives aren't strictly necessary, as the only real difference between I made a serious effort to include System.ArgumentNullException as a polyfill (similar to this example), but the challenge is that there's no straightforward way to throw a System.ArgumentNullException in that context, as it would reference its own type. |
based on this article I removed |
I appreciate that you have a situation where you need to support older framework. If there is a problem in the legacy branch that prevent usage, please report a bug Again, thank you for taking the time and making an effort towards this library! |
What specific features do you expect to use in this library? Modern language features are already accessible through PolySharp, and given the minimal external dependencies, I’m struggling to see what additional framework features would be relevant 🤷🏻. The main limitation right now is the absence of ArgumentNullException.ThrowIfNull in Update Maybe you like this implementation better? Less use of compiler directives, only for the method inlining which could also be considered optional: main...riezebosch:Xoxo:feat/netstandard2.0 |
I've reintroduced
netstandard2.0
support to enable usage from a net48 project. Unfortunately, we're still tied to net48 due to WCF incompatibilities. 😢