dgm9704 · riezebosch · Jan 14, 2025
diff --git a/Diwen.Xbrl/ArgumentNullException.cs b/Diwen.Xbrl/ArgumentNullException.cs
@@ -0,0 +1,25 @@
+#if NETSTANDARD2_0
+
+using System.Runtime.CompilerServices;
+
+namespace Diwen.Compat;
+
+/// <summary>
+/// Polyfill for the ArgumentNullException factory method from net6.0+
+/// </summary>
+public static class ArgumentNullException
+{
+    /// <summary>Throws an <see cref="T:System.ArgumentNullException" /> if <paramref name="argument" /> is <see langword="null" />.</summary>
+    /// <param name="argument">The reference type argument to validate as non-null.</param>
+    /// <param name="paramName">The name of the parameter with which <paramref name="argument" /> corresponds.</param>
+    /// <exception cref="T:System.ArgumentNullException">
+    /// <paramref name="argument" /> is <see langword="null" />.</exception>
+    public static void ThrowIfNull(object argument, [CallerArgumentExpression("argument")] string paramName = null)
+    {
+        if (argument is null)
+        {
+            throw new System.ArgumentNullException(paramName);
+        }
+    }
+}
+#endif
diff --git a/Diwen.Xbrl/Csv/Report.cs b/Diwen.Xbrl/Csv/Report.cs
@@ -12,6 +12,9 @@
     using Diwen.Xbrl.Csv.Taxonomy;
     using Diwen.Xbrl.Extensions;
     using Diwen.Xbrl.Xml;
+#if NETSTANDARD2_0
+    using ArgumentNullException = Compat.ArgumentNullException;
+#endif
 
         /// <summary/>
     public partial class Report

diff --git a/Diwen.Xbrl/Diwen.Xbrl.csproj b/Diwen.Xbrl/Diwen.Xbrl.csproj
@@ -1,6 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 	<PropertyGroup>
-		<TargetFramework>net8.0</TargetFramework>
+		<TargetFrameworks>netstandard2.0;net8.0</TargetFrameworks>
+		<LangVersion>latest</LangVersion>
 		<Version>3.4.1</Version>
 	</PropertyGroup>
 
@@ -21,6 +22,14 @@
 		<GenerateDocumentationFile>true</GenerateDocumentationFile>
 	  </PropertyGroup>
 
+	<ItemGroup>
+	  <PackageReference Include="PolySharp" Version="1.15.0">
+	    <PrivateAssets>all</PrivateAssets>
+	    <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
+	  </PackageReference>
+	  <PackageReference Include="System.Text.Json" Version="9.0.0" Condition="'$(TargetFramework)' == 'netstandard2.0'" />
+	</ItemGroup>
+
 	<Target Name="Date" BeforeTargets="BeforeBuild">
 		<WriteLinesToFile File="$(IntermediateOutputPath)gen.cs"
 			Lines="static partial class Builtin { public static long CompileTime = $([System.DateTime]::UtcNow.Ticks) %3B }"

diff --git a/Diwen.Xbrl/Extensions/XmlQualifiedNameExtensions.cs b/Diwen.Xbrl/Extensions/XmlQualifiedNameExtensions.cs
@@ -23,6 +23,9 @@ namespace Diwen.Xbrl.Extensions
 {
     using System;
     using System.Xml;
+#if NETSTANDARD2_0
+    using ArgumentNullException = Compat.ArgumentNullException;
+#endif
 
     /// <summary/>
     public static class XmlQualifiedNameExtensions

diff --git a/Diwen.Xbrl/Inline/InlineXbrl.cs b/Diwen.Xbrl/Inline/InlineXbrl.cs
@@ -94,7 +94,7 @@ public static void ParseFacts(XDocument document, Report report)
                 if (!string.IsNullOrWhiteSpace(scale))
                 {
                     var power = int.Parse(scale);
-                    var v = decimal.Parse(value.Replace(" ", ""));
+                    var v = decimal.Parse(value.Replace(" ", ""), CultureInfo.InvariantCulture);
                     var multiplier = (decimal)Math.Pow(10, power);
                     v *= multiplier;
                     value = v.ToString();

diff --git a/Diwen.Xbrl/Json/Report.cs b/Diwen.Xbrl/Json/Report.cs
@@ -158,7 +158,7 @@ public static Xml.Report ToXbrlXml(Report report, Dictionary<string, string> dim
                 context.Period = period;
 
                 var metric = fact.Dimensions["concept"].Split(':').Last();
-                var unitValue = fact.Dimensions.GetValueOrDefault("unit");
+                var unitValue = fact.Dimensions.GetValueOrDefault("unit", null);
                 string unitRef = null;
                 if (unitValue != null)
                 {

diff --git a/Diwen.Xbrl/Xml/ContextCollection.cs b/Diwen.Xbrl/Xml/ContextCollection.cs
@@ -26,6 +26,9 @@ namespace Diwen.Xbrl.Xml
     using System.Collections.ObjectModel;
     using System.Globalization;
     using Diwen.Xbrl.Extensions;
+#if NETSTANDARD2_0
+    using ArgumentNullException = Compat.ArgumentNullException;
+#endif
 
     /// <summary/>
     public class ContextCollection : KeyedCollection<string, Context>, IEquatable<IList<Context>>

diff --git a/Diwen.Xbrl/Xml/ExplicitMember.cs b/Diwen.Xbrl/Xml/ExplicitMember.cs
@@ -27,6 +27,9 @@ namespace Diwen.Xbrl.Xml
     using System.Xml.Schema;
     using System.Xml.Serialization;
     using Diwen.Xbrl.Extensions;
+#if NETSTANDARD2_0
+    using ArgumentNullException = Compat.ArgumentNullException;
+#endif
 
     /// <summary/>
     [XmlRoot(ElementName = "explicitMember", Namespace = "http://xbrl.org/2006/xbrldi")]

diff --git a/Diwen.Xbrl/Xml/Fact.cs b/Diwen.Xbrl/Xml/Fact.cs
@@ -26,6 +26,9 @@ namespace Diwen.Xbrl.Xml
     using System.Xml;
     using System.Xml.Serialization;
     using Diwen.Xbrl.Extensions;
+#if NETSTANDARD2_0
+    using ArgumentNullException = Compat.ArgumentNullException;
+#endif
 
     /// <summary/>
     public class Fact : IEquatable<Fact>

diff --git a/Diwen.Xbrl/Xml/FilingIndicator.cs b/Diwen.Xbrl/Xml/FilingIndicator.cs
@@ -25,6 +25,9 @@ namespace Diwen.Xbrl.Xml
     using System.Diagnostics;
     using System.Xml.Schema;
     using System.Xml.Serialization;
+#if NETSTANDARD2_0
+    using ArgumentNullException = Compat.ArgumentNullException;
+#endif
 
     /// <summary/>
     [DebuggerDisplay("{Value} : {Filed}")]

diff --git a/Diwen.Xbrl/Xml/Report.cs b/Diwen.Xbrl/Xml/Report.cs
@@ -31,6 +31,9 @@ namespace Diwen.Xbrl.Xml
     using System.Xml;
     using System.Xml.Serialization;
     using Diwen.Xbrl.Extensions;
+#if NETSTANDARD2_0
+    using ArgumentNullException = Compat.ArgumentNullException;
+#endif
 
     /// <summary/>
     [Serializable]
@@ -114,7 +117,7 @@ public Entity Entity
         [XmlIgnore]
         public SchemaReference SchemaReference
         {
-            get => SchemaReferences?.FirstOrDefault(new SchemaReference());
+            get => SchemaReferences?.FirstOrDefault() ?? new SchemaReference();
             set => SchemaReferences = [value];
         }
 

diff --git a/Diwen.Xbrl/Xml/TypedMember.cs b/Diwen.Xbrl/Xml/TypedMember.cs
@@ -26,6 +26,9 @@ namespace Diwen.Xbrl.Xml
     using System.Xml.Schema;
     using System.Xml.Serialization;
     using Diwen.Xbrl.Extensions;
+#if NETSTANDARD2_0
+    using ArgumentNullException = Compat.ArgumentNullException;
+#endif
 
     /// <summary/>
     [XmlRoot(ElementName = "typedMember", Namespace = "http://xbrl.org/2006/xbrldi")]

diff --git a/Diwen.Xbrl/Xml/TypedMemberCollection.cs b/Diwen.Xbrl/Xml/TypedMemberCollection.cs
@@ -28,6 +28,9 @@ namespace Diwen.Xbrl.Xml
     using System.Xml;
     using System.Xml.Serialization;
     using Diwen.Xbrl.Extensions;
+#if NETSTANDARD2_0
+    using ArgumentNullException = Compat.ArgumentNullException;
+#endif
 
     /// <summary/>
     public class TypedMemberCollection : Collection<TypedMember>, IEquatable<IList<TypedMember>>

diff --git a/Diwen.Xbrl/Xml/Unit.cs b/Diwen.Xbrl/Xml/Unit.cs
@@ -27,7 +27,10 @@ namespace Diwen.Xbrl.Xml
     using System.Xml.Schema;
     using System.Xml.Serialization;
     using Diwen.Xbrl.Extensions;
-
+#if NETSTANDARD2_0
+    using ArgumentNullException = Compat.ArgumentNullException;
+#endif
+
     /// <summary/>
     [DebuggerDisplay("{Id}")]
     [Serializable]