SMV netlist: translate some SVA to LTL #1051
Merged
+80
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kroening
force-pushed
the
SVA_to_LTL
branch
2 times, most recently
from
aadac0c to
d4d83c6
Compare
tautschnig
approved these changes
Apr 8, 2025
Comment on lines
227
to
284
| else if(!has_temporal_operator(expr)) | ||
| return expr; |
There was a problem hiding this comment.
Wouldn't moving this case before the else if(expr.id() == ID_and ...) avoid unnecessary copying when it is a conjunction/disjunction/etc. without temporal operators?
Parts of SVA map directly to LTL. This allows extending the set of formulas converted to LTL when outputting an SMV model.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parts of SVA map directly to LTL. This allows extending the set of formulas converted to LTL when outputting an SMV model.