Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable noUncheckedSideEffectImports TypeScript option #861

Merged
merged 3 commits into from
Sep 24, 2024

Commits on Sep 24, 2024

  1. chore: update to TypeScript 5.6

    This change should have no user impact.
    
    This updates TypeScript to the latest version, 5.6.2. It also updates
    `typedoc` dependencies to their latest versions.
    
    I verified that the generated types in `dist/` were not meaningfully
    changed. (Some `Iterator` types were slightly adjusted, as expected;
    [TypeScript 5.6 made some changes to how `Iterator` types work][0].)
    
    [0]: https://devblogs.microsoft.com/typescript/announcing-typescript-5-6/#iterator-helper-methods
    EvanHahn committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    8e93fb9 View commit details
    Browse the repository at this point in the history
  2. chore: enable noUncheckedSideEffectImports TypeScript option

    This change should have no user impact.
    
    [`noUncheckedSideEffectImports`][0] checks side-effect imports, such as:
    
    ```typescript
    // Not actually importing anything from this module.
    import 'example'
    ```
    
    This enables that option.
    
    No code changes were required; it may help avoid future mistakes.
    
    [0]: https://www.typescriptlang.org/tsconfig/#noUncheckedSideEffectImports
    EvanHahn committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    c0ec11f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7d07b8c View commit details
    Browse the repository at this point in the history