Upgrade React Native to 0.66 #867
Conversation
There was a problem hiding this comment.
So two outstanding issues to fix:
- Ensuring that sync will work if we're using Node v12.19.0 (from [email protected])
- Fixing version numbers in bugsnag
|
After internal discussion, going to do the following to make this PR less daunting and safer:
See #887 |
| @@ -4,6 +4,7 @@ | |||
| <uses-permission android:name="android.permission.INTERNET" /> | |||
| <uses-permission android:name="android.permission.ACCESS_COARSE_LOCATION" /> | |||
| <uses-permission android:name="android.permission.ACCESS_FINE_LOCATION" /> | |||
| <uses-permission android:name="android.permission.FOREGROUND_SERVICE" /> | |||
There was a problem hiding this comment.
for context, think this is automatically added via expo-location but explicitly added here for clarity
https://github.com/expo/expo/tree/master/packages/expo-location#configure-for-android
| uses: actions/setup-node@v2 | ||
| with: | ||
| node-version: "12.16.3" |
There was a problem hiding this comment.
the upgrade of @react-native-community/cli (which is used to run android build steps) requires Node >=12
There was a problem hiding this comment.
Interesting I had thought we were already using Node 12 for builds. It's set in .nvmrc, but I don't think Github actions pay attention to that file. The other two places this matters are in Bitrise and Cirrus CI. Bitrise respects .nvmrc because it uses nvm to manage Node (https://github.com/digidem/mapeo-mobile/blob/develop/bitrise.yml#L326). Cirrus CI uses a Docker container that we build ourselves, and that is currently set to 12.x e.g. Node v12 latest (https://github.com/digidem/docker-android/blob/master/Dockerfile#L16). So I think we should be ok for this change, just wanted to make sure you are aware of all these pieces.
There was a problem hiding this comment.
Certain parts of the build process were using Node 12, but they had node-version specified. Without it version 10 was being installed (or used via the cache).
Regardless, the additional context is appreciated 👍
Closes #840
Open questions so far:
react-native-fsmay cause us problems after the bump to the sdk version we target (30). Several issues on the repo questioning whether it's actively maintained and there seem to be many issues with it on Android 11. More importantly, based on Android 11 new policy "MANAGE_EXTERNAL_STORAGE" itinance/react-native-fs#998 seems like submission won't even be allowed to the Play Store unless we patch something? All in all, I think we may need to look into a better maintained alternativeKnown issues:
react-native-splash-screensand seems like it's not maintained well enough for it to be resolved. general consensus has been to usereact-native-bootsplashinstead, which I have mostly working on a local branch. The only thing that needs to be addressed is getting the ICCA assets generated (I basically just need the Mapeo logo with the ICCA copy to generate the necessary assets) cc @gmaclennanRemaining work:
Dependency changes:
v8-android@types):metro-configreact-native-codegen@react-native-mapbox/maps(8.0.0 -> 8.5.0)nodejs-mobile-react-native(0.6.1 -> 0.6.3)react(16.13.1 -> 17.0.2)react-native(0.63.4 -> 0.66.4)react-native-device-info(5.6.3 -> 8.4.8)react-native-v8(0.63.2-patch.0 -> 0.66.3-patch.1)@types):@babel/core(7.11.1 -> 7.12.17)@babel/runtime(7.11.2 -> 7.12.18)@react-native-community/cli(4.12.0 -> 6.2.0)babel-jest(25.3.0 -> 26.6.3)eslint(7.6.0 -> 7.14.0)flow-bin(0.122.0 -> 0.149.0)metro-react-native-babel-preset(0.61.0 -> 0.66.2)react-dom(16.13.1 -> 17.0.2)react-test-renderer(16.13.1 -> 17.0.2)@types):