-
Notifications
You must be signed in to change notification settings - Fork 16
Upgrade React Native to 0.66 #867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
83 commits
Select commit
Hold shift + click to select a range
67d9f85
WIP: rebased onto develop after 0.65 work
achou11 2c05a45
WIP: changes for RN 0.66
achou11 5659d4c
WIP: patches. app builds locally but cannot open
achou11 7c3aedd
Revert some build.gradle changes
achou11 9875757
Bump metro-react-native-babel-preset
achou11 8dc79cb
fix: Fix nodejs-mobile patch
gmaclennan cbd83da
fix: Fix nodejs-mobile patch again
gmaclennan 34c4488
chore: update package-lock.json
gmaclennan 03c7153
chore: update react-native cli
gmaclennan 795879a
Update package.json with cli upgrade
achou11 6ab26c9
chore: Fix metro config
gmaclennan 5a1154b
chore: Add metro-config as dep
gmaclennan 91b1e3c
chore: try to fix react-native cli issues
gmaclennan 01ea2db
chore: fix metro config
gmaclennan 4187209
fix: nodejs-mobile native builds
gmaclennan 32b8bd9
chore: update react-native-v8
gmaclennan e48a35d
chore: udpate chromium version for v8
gmaclennan 87ba785
chore: fix missing full-stop
gmaclennan e09625b
chore: fix react-native-v8 by installing v8-android manually
gmaclennan c23c878
chore: fix react-native-screens modifications from years ago
gmaclennan 4694a18
chore: Update react-native-screens@2.18.1
gmaclennan d4e9fce
chore: pin to babel@7.12.* to avoid build errors
gmaclennan 2fce1ee
chore: HACKY fix - force babel resolution to v7.12
gmaclennan 7405062
Revert "chore: HACKY fix - force babel resolution to v7.12"
achou11 e1382fa
Downgrade to RN 0.65
achou11 ddcffb8
Revert "Downgrade to RN 0.65"
achou11 07cde63
Upgrade RN CLI
achou11 492eaa3
Fix potential issue in async storage
achou11 6c49cc2
Add patch to fix metro-transform-worker
achou11 301fca5
Upgrade React Native to 0.66.3
achou11 667c2d4
Fix soloader crash on startup
achou11 9e7d1c1
Add comment about needing to keep jcenter
achou11 2027f2a
Fix incorrect integration of new Bugsnag API
achou11 857212c
Upgrade nodejs-mobile-react-native to 0.6.3
achou11 cc4fc82
Update react-native-v8
achou11 4a35878
Update api.js to not use channel.once
achou11 f585529
Update nodejs channel usage of listeners since removeListener is depr…
achou11 18b7956
Update @types/react-native
achou11 c9a40b7
Update @types/react and @types/react-dom
achou11 d9a5d7e
Update @react-native-mapbox-gl/maps
achou11 c1089d2
Convert logger to TS and comment out release stage logic for Bugsnag
achou11 f33e0a9
WIP: potential bug introduced for apploading when pressing permission…
achou11 de31784
WIP
achou11 835d284
fix startServer issue on app start after permissions prompt
achou11 3bb10fe
Fix alert dialog theming
achou11 77db8d4
Update @react-native-community/hooks to fix one of several removeList…
achou11 69fccc6
Revert "WIP"
achou11 f96b45f
Fix onPress event deprecation notice on ShapeSource
achou11 525babf
Update navigation focus listener to address removeEventListener depre…
achou11 71b8197
Suppress noisy and expected logs from Mapbox
achou11 28bfc9a
Update react-native-devie-info to fix removeEventListener warning
achou11 c875543
Update @react-native-community/netinfo to fix removeEventListener war…
achou11 187d513
Remove commented-out soloader fix in build.gradle
achou11 cb2b7ec
Merge branch 'develop' into ac/rn-upgrade-66
achou11 678ccd3
Upgrade to React Native 0.66.4
achou11 291ddbf
Merge branch 'develop' into ac/rn-upgrade-66
achou11 fbab72a
Remove unnecessary check in logger
achou11 c584ad2
Fix server status state type in AppLoading
achou11 e52f7da
Remove unnecessary onPress handler on map view
achou11 48dab34
Update splashscreen timeout handling in AppLoading
achou11 2cb8d77
Refactor server status code in AppLoading to create hook
achou11 9abfda5
Bump supportLibVersion to 30
achou11 d30ff96
Remove @react-native-community/art
achou11 84f2dc9
Remove @react-native-community/masked-view
achou11 12666f3
Remove jsdom-jscore-rn
achou11 87e7331
Remove react-to-string
achou11 ebb9d0a
Add comment about why inlineRequires is set to false
achou11 565b7a2
Upgrade async-storage
achou11 0fa07db
Revert "Remove @react-native-community/art"
achou11 8ce6b5d
Revert "Remove @react-native-community/masked-view"
achou11 2bade61
Remove old LocationContext file
achou11 b852e74
Move useServerStatus hook to AppLoading
achou11 247ea9c
Merge branch 'develop' into ac/rn-upgrade-66
achou11 a873b72
Initial pass at setting Bugsnag release stage at build time
achou11 264505d
Remove console.log in MapView
achou11 d915621
Merge branch 'develop' into ac/rn-upgrade-66
achou11 f0ca4fb
Merge branch 'develop' into ac/rn-upgrade-66
achou11 835cd4b
Remove jsdom-jscore-rn
achou11 0c29e12
testing if CI is fixed using consistent version of node
achou11 01b1d4e
temp: maybe fix CI by clearing gradle cache before building detox
achou11 c41d1dc
Revert "temp: maybe fix CI by clearing gradle cache before building d…
achou11 9af27a7
Potentially fix issue with appcompat issue in detox build
achou11 845dc55
Merge branch 'develop' into ac/rn-upgrade-66
achou11 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| *.pbxproj -text | ||
| # specific for windows script files | ||
| # Windows files should use crlf line endings | ||
| # https://help.github.com/articles/dealing-with-line-endings/ | ||
| *.bat text eol=crlf |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| distributionBase=GRADLE_USER_HOME | ||
| distributionPath=wrapper/dists | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-6.2-all.zip | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-6.9-all.zip | ||
| zipStoreBase=GRADLE_USER_HOME | ||
| zipStorePath=wrapper/dists |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the upgrade of
@react-native-community/cli(which is used to run android build steps) requires Node >=12There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting I had thought we were already using Node 12 for builds. It's set in
.nvmrc, but I don't think Github actions pay attention to that file. The other two places this matters are in Bitrise and Cirrus CI. Bitrise respects.nvmrcbecause it uses nvm to manage Node (https://github.com/digidem/mapeo-mobile/blob/develop/bitrise.yml#L326). Cirrus CI uses a Docker container that we build ourselves, and that is currently set to12.xe.g. Node v12 latest (https://github.com/digidem/docker-android/blob/master/Dockerfile#L16). So I think we should be ok for this change, just wanted to make sure you are aware of all these pieces.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Certain parts of the build process were using Node 12, but they had
node-versionspecified. Without it version 10 was being installed (or used via the cache).Regardless, the additional context is appreciated 👍