Add support for internal copy in S3 blob db #13203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -8,7 +9,7 @@ | |||
| from corehq.blobs.util import ClosingContextProxy | |||
|
|
|||
| import boto3 | |||
| from boto3.s3.transfer import S3Transfer, ReadFileChunk | |||
| from boto3.s3.transfer import S3Transfer | |||
There was a problem hiding this comment.
F401 'S3Transfer' imported but unused
Internal copy performs an efficient copy operation when `put`ting a blob that was previously loaded using `get`. A new version of boto3 (v1.4.0) is needed for the copy operation. The upgrade also simplified multipart upload support.
millerdev
force-pushed
the
dm/s3db-fast-copy
branch
from
dd85087
to
f2a1b5d
Compare
| return self | ||
|
|
||
| def __exit__(self, *args, **kwargs): | ||
| self.close() |
|
Nice |
| osutil = OpenFileOSUtils() | ||
| transfer = S3Transfer(self.db.meta.client, osutil=osutil) | ||
| transfer.upload_file(content, self.s3_bucket_name, path) | ||
| self._s3_bucket().upload_fileobj(content, path) |
There was a problem hiding this comment.
Notable difference in new upload_fileobj implementation in boto3 (v1.4.0): boto/s3transfer#52
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal copy performs an efficient copy operation when
putting a blob that was previously loaded usingget.A new version of boto3 (v1.4.0) is needed for the copy operation. The upgrade also simplified multipart upload support.
@snopoke cc @NoahCarnahan