This repository was archived by the owner on Jul 14, 2025. It is now read-only.
DEV: Puts full name updates behind hidden setting #655
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
featheredtoast
approved these changes
Apr 10, 2025
brrusselburg
changed the title
|
closing in favor of Juan's PR which includes the js |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of relying on the
prioritize_username_in_uxfield, we want to ensure this doesn't impact anyone that currently has that setting set tofalse. This changes the gating to be done by a hidden setting:prioritize_full_name_in_ux.In the future, this feature may be moved from a hidden setting to one in the UI, but for now this will do.