Skip to content
This repository was archived by the owner on Jul 14, 2025. It is now read-only.
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/assigner.rb
Original file line number Diff line number Diff line change
Expand Up @@ -492,7 +492,7 @@ def queue_notification(assignment)
end

def small_action_username_or_name(assign_to)
if (assign_to.is_a?(User) && !SiteSetting.prioritize_username_in_ux) ||
if (assign_to.is_a?(User) && SiteSetting.prioritize_full_name_in_ux) ||
!assign_to.try(:username)
custom_fields = { "action_code_who" => assign_to.name || assign_to.username }
else
Expand Down
3 changes: 1 addition & 2 deletions spec/system/assign_post_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
before do
skip "Tests are broken and need to be fixed. See https://github.com/discourse/discourse/actions/runs/13890376408/job/38861216842"
SiteSetting.assign_enabled = true
SiteSetting.prioritize_username_in_ux = true
# The system tests in this file are flaky and auth token related so turning this on
SiteSetting.verbose_auth_token_logging = true

Expand Down Expand Up @@ -61,7 +60,7 @@ def assign_post(post, assignee)
end

context "when prioritize_full_name_in_ux setting is enabled" do
before { SiteSetting.prioritize_username_in_ux = false }
before { SiteSetting.prioritize_full_name_in_ux = true }

it "shows the user's name after assign" do
visit "/t/#{topic.id}"
Expand Down
2 changes: 1 addition & 1 deletion spec/system/assign_topic_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
end

context "when prioritize_full_name_in_ux setting is enabled" do
before { SiteSetting.prioritize_username_in_ux = false }
before { SiteSetting.prioritize_full_name_in_ux = true }

it "shows the user's name after assign" do
visit "/t/#{topic.id}"
Expand Down
Loading