Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature #1366 : make right sidebar independent from main content #1379

Closed
wants to merge 4 commits into from
Closed

Feature #1366 : make right sidebar independent from main content #1379

wants to merge 4 commits into from

Conversation

nandanchandra
Copy link

Issue : #1366
issue

Hello maintainers, I have updated the scrollable functionality to sidebar-right .

@sabderemane sabderemane requested a review from a team July 13, 2023 01:48
Comment on lines +452 to +454
& ::-webkit-scrollbar {
width: 0;
}
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you remove the width of the scrollbar here ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @sabderemane,
Setting the width to 0 hides the default scrollbar, as the UI is not that good for the default one.

Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should never hide the scrollbar. That’s how users can tell the area is scrollable to start with, and lots of people interact with the scrollbar to scroll.

Copy link
Sponsor Member

@thibaudcolas thibaudcolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn’t look quite right to me. The pattern we want here has different characteristics:

  • We’d want two scrollable areas – the sidebar, and the rest of the page. This has 3 areas as-is: sidebar, main area, rest of the page.
  • We’d also want the sidebar to be sticky I believe.
  • And I’m not convinced this is something it makes sense to implement site-wide (at least with the current site design & content model). For documentation sites where the sidebar is only navigation, it makes sense. In the case of Django we also sometimes have regular content in the sidebar.

All in all I think this is the type of large design change it’d make more sense to consider as part of the djangoproject.com redesign (for reference: survey form, I don’t have a better ref).

@@ -436,13 +436,22 @@ blockquote {
@include respond-min(768px) {
margin: 0 auto;
max-width: 1400px;
padding: 0 (32/768) * 100%;
padding: 0 calc(32 / 768 * 100%);
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This produces the same result with Sass and vanilla CSS computation so I don’t understand this change?

Comment on lines +452 to +454
& ::-webkit-scrollbar {
width: 0;
}
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should never hide the scrollbar. That’s how users can tell the area is scrollable to start with, and lots of people interact with the scrollbar to scroll.

@nandanchandra nandanchandra closed this by deleting the head repository Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants