Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature #1366 : make right sidebar independent from main content #1379

Closed
wants to merge 4 commits into from
Closed

Feature #1366 : make right sidebar independent from main content #1379

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
963a9d1
feat:right-sidebar-scss-changes(#1366)
nandanchandra Jun 14, 2023
d7db76d
feat:right-sidebar-scroll(#1366)
nandanchandra Jun 17, 2023
b7a71fa
feat:right-sidebar-clean-code(#1366)
nandanchandra Jun 19, 2023
5e429c3
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jun 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion djangoproject/scss/_style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,13 +436,22 @@ blockquote {
@include respond-min(768px) {
margin: 0 auto;
max-width: 1400px;
padding: 0 (32/768) * 100%;
padding: 0 calc(32 / 768 * 100%);
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This produces the same result with Sass and vanilla CSS computation so I don’t understand this change?

}

&.sidebar-right {
.mdzr-boxshadow & {
box-shadow: -1200px 0 0 0px var(--white-color);
}

div[role="main"],
div[role="complementary"] {
max-height: 100vh;
overflow-y: scroll;
}
& ::-webkit-scrollbar {
width: 0;
}
Comment on lines +452 to +454
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you remove the width of the scrollbar here ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @sabderemane,
Setting the width to 0 hides the default scrollbar, as the UI is not that good for the default one.

Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should never hide the scrollbar. That’s how users can tell the area is scrollable to start with, and lots of people interact with the scrollbar to scroll.

}
}

Expand Down
Loading