fix(web): add explicit ARIA role='region' to ActivityPane section (#3672) - #3713
fix(web): add explicit ARIA role='region' to ActivityPane section (#3672)#3713djm204 wants to merge 4 commits into
Conversation
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 11d8e9892e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
11d8e98 to
9fe6e86
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Closing without merge because the immutable exact head Closeout evidence:
Issue #3672 remains open for a future merge-eligible implementation. This PR is closed at the immutable reviewed head rather than merged through red CI. |
Fixes #3672.
Description
The
ActivityPanecomponent rendered its activity stream in a<section>witharia-label="Activity"but lacked an explicit ARIA landmarkrole="region", hindering keyboard and assistive technology navigation.Changes
role="region"attribute to<section>inpackages/franken-web/src/components/activity-pane.tsx.packages/franken-web/tests/components/activity-pane.test.tsxverifying landmark accessibility attributes and rendering.