Skip to content

fix(web): add explicit ARIA role='region' to ActivityPane section (#3672) - #3713

Closed
djm204 wants to merge 4 commits into
mainfrom
fix/issue-3672-activity-pane-aria-role
Closed

fix(web): add explicit ARIA role='region' to ActivityPane section (#3672)#3713
djm204 wants to merge 4 commits into
mainfrom
fix/issue-3672-activity-pane-aria-role

Conversation

@djm204

@djm204 djm204 commented Jul 24, 2026

Copy link
Copy Markdown
Owner

Fixes #3672.

Description

The ActivityPane component rendered its activity stream in a <section> with aria-label="Activity" but lacked an explicit ARIA landmark role="region", hindering keyboard and assistive technology navigation.

Changes

  • Added role="region" attribute to <section> in packages/franken-web/src/components/activity-pane.tsx.
  • Created unit tests in packages/franken-web/tests/components/activity-pane.test.tsx verifying landmark accessibility attributes and rendering.

@djm204

djm204 commented Jul 24, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 11d8e9892e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/franken-critique/src/evaluators/conciseness.ts Outdated
Comment thread packages/franken-critique/src/breakers/token-budget.ts Outdated
Comment thread docs/plans/2026-07-01-deploy-beasts-sprint.md
Comment thread tasks/issue-3672-activity-pane-aria-role-progress.md Outdated
@djm204
djm204 force-pushed the fix/issue-3672-activity-pane-aria-role branch from 11d8e98 to 9fe6e86 Compare July 30, 2026 02:50
@djm204

djm204 commented Aug 9, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. More of your lovely PRs please.

Reviewed commit: c9fc703146

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@djm204

djm204 commented Aug 9, 2026

Copy link
Copy Markdown
Owner Author

Closing without merge because the immutable exact head c9fc703146aac0bcaf75158dd717dbfc6f79e589 is not eligible under the no-bypass closeout gate.

Closeout evidence:

Issue #3672 remains open for a future merge-eligible implementation. This PR is closed at the immutable reviewed head rather than merged through red CI.

@djm204 djm204 closed this Aug 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add missing ARIA role to ActivityPane section for screen‑reader navigation

1 participant