Skip to content

fix(web): add explicit ARIA role='region' to ActivityPane section (#3672) #3713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
djm204 wants to merge 4 commits into from
Closed

fix(web): add explicit ARIA role='region' to ActivityPane section (#3672) #3713

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e28f765
fix(critique): validate tokenBudget and costBudgetUsd in TokenBudgetB…
djm204 Jul 24, 2026
67fd5f8
perf(critique): bound ConcisenessEvaluator input memory and processin…
djm204 Jul 24, 2026
9fe6e86
fix(web): add explicit ARIA role='region' to ActivityPane section (#3…
djm204 Jul 24, 2026
c9fc703
fix(web): merge main into activity pane accessibility fix
djm204 Aug 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/franken-web/src/components/activity-pane.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,13 @@ describe('ActivityPane', () => {
vi.restoreAllMocks();
});

it('exposes the activity pane as a named region landmark', () => {
render(<ActivityPane events={[]} />);

const region = screen.getByRole('region', { name: 'Activity' });
expect(region.tagName).toBe('SECTION');
});

it('summarizes turn errors and keeps raw data behind details', () => {
render(
<ActivityPane
Expand Down
2 changes: 1 addition & 1 deletion packages/franken-web/src/components/activity-pane.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ export function ActivityPane({ events, resetKey }: ActivityPaneProps) {
}, [events.length, latestAnnouncement, resetKey]);

return (
<section className="rail-card terminal-activity" aria-label="Activity">
<section className="rail-card terminal-activity" role="region" aria-label="Activity">
<div className="rail-card__header">
<p className="eyebrow">Activity</p>
<h2>Runtime Events</h2>
Expand Down
Loading