Merged
Conversation
Ensures trader entities (chests, tanks, accumulators) are assigned to the player''s force when built, preventing them from becoming neutral faction entities that cause items to disappear and money to be lost. This implements the community-suggested fix from moullcz by adding force assignment logic in the on_creation event handler for all trader entity types. Co-authored-by: Sulaiman Khan Ghori <djmango@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22
Ensures trader entities (chests, tanks, accumulators) are assigned to the player's force when built, preventing them from becoming neutral faction entities that cause items to disappear and money to be lost.
This implements the community-suggested fix from moullcz by adding force assignment logic in the on_creation event handler for all trader entity types.
Generated with Claude Code