Skip to content

Fix multiplayer neutral chest bug (#22) #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
djmango merged 1 commit into from
Jul 18, 2025
Merged

Fix multiplayer neutral chest bug (#22) #96

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions control.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2594,12 +2594,17 @@ local function on_creation(event)
end

if sell_or_buy ~= nil then
-- Fix for neutral chest bug (issue #22): ensure trader entities are bound to player's force
if event.player_index then
local player = game.get_player(event.player_index)
if player and player.valid then
ent.force = player.force
end
end

local suffix = string.sub(ent_name, 16, 19)
local level = suffix_to_level(suffix)
local force_mem = storage.force_mem[ent.force.name]
-- if ent.force.name = 'neutral' then force_mem = storage.force_mem['player'] end
-- this is how you would fix the neutral chest bug, see issue 22, however i cant find
-- that setting to test it so im not exactly sure whats up
local trader = { entity = ent, sell_or_buy = sell_or_buy, type = type }
init_trader(trader, level)
trader.n_period = force_mem.n_period
Expand Down
Loading