Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create asset modified cleanup handler #856

Closed
wants to merge 69 commits into from

Conversation

JackLewis-digirati
Copy link
Contributor

@JackLewis-digirati JackLewis-digirati commented May 23, 2024

Resolves #430
links WDLS-507

This PR reimplements work done on #841 as well as implementing the work required by the asset modified cleanup handler.

It includes a new appsettings section:

"AssetModifiedSettings": {
  "DryRun": false,
  "EngineRoot": "https://localhost:7014"
},

And

"UpdateNotificationQueueName": "dlcsspinup-update-notification"

DryRun determines whether the application should actually remove files/db entries and is false by default
EngineRoot is used for setting the engine URI, which is used by the cleanup handler to retrieve details encoding presets from engine

Additional changes in this PR includes allowing the cleanup handler to listen to multiple SQS queues and an additional endpoint added to the engine for retrieving a dictionary of presets

UpdateNotificationQueueName details the name of the queue

@JackLewis-digirati JackLewis-digirati changed the title reate asset modified cleanup handler Create asset modified cleanup handler May 23, 2024
@JackLewis-digirati JackLewis-digirati marked this pull request as ready for review May 23, 2024 13:36
@JackLewis-digirati JackLewis-digirati requested a review from a team as a code owner May 23, 2024 13:36
@JackLewis-digirati JackLewis-digirati force-pushed the feature/assetModifiedCleanupHandler branch 2 times, most recently from 3c58977 to ac541d9 Compare May 29, 2024 13:48
.AddSingleton<IStorageKeyGenerator, S3StorageKeyGenerator>()
.AddSingleton<IQueueLookup, SqsQueueLookup>()
.AddSingleton<IQueueSender, SqsQueueSender>()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not worth changing, just an observation, but the fact that these 2 IQueue* dependencies are brought in due to use of IEngineClient doesn't feel right. We should maybe have an IEngineClient for ingesting and another for querying the api.. 🤔

src/protagonist/DLCS.Repository/Messaging/EngineClient.cs Outdated Show resolved Hide resolved
src/protagonist/CleanupHandler/AssetUpdatedHandler.cs Outdated Show resolved Hide resolved
src/protagonist/CleanupHandler/AssetUpdatedHandler.cs Outdated Show resolved Hide resolved
src/protagonist/CleanupHandler/AssetUpdatedHandler.cs Outdated Show resolved Hide resolved
JackLewis-digirati and others added 27 commits July 4, 2024 01:58
Adding abilty to use a stickiness cookie when generating thumbs through cantaloupe
…with modified notification sending before like after
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete no-longer required delivery artifacts
3 participants