-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs/issue 1661 add tip to source docs and update weaviate docs #1662
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
c0fa9d8
Added tip to the source doc about max_table_nesting`
dat-a-man 44854dc
Updated docs, added tip to source docs.
dat-a-man b2759c6
Added example for adaptation best practise and using multiple sources
dat-a-man 662a437
Updated for comments and added adapter info to qdrant and lancedb.
dat-a-man 3e275d4
Added tip to the source documentation
dat-a-man 0506c3a
Updated as per comments
dat-a-man 2dcb8d7
Updated lancedb.md and qdrant.md
dat-a-man 4079287
Merge remote-tracking branch 'origin/devel' into docs/issue-1661-add-…
dat-a-man 2c0d6b5
Updated
dat-a-man File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -187,6 +187,26 @@ Several data sources are prone to contain semi-structured documents with very de | |||||||||||||
MongoDB databases. Our practical experience is that setting the `max_nesting_level` to 2 or 3 | ||||||||||||||
produces the clearest and human-readable schemas. | ||||||||||||||
|
||||||||||||||
:::tip | ||||||||||||||
The `max_table_nesting` parameter at the source level doesn't automatically apply to individual | ||||||||||||||
resources when accessed directly (e.g., using `source.resources["resource_1"])`. To make sure it | ||||||||||||||
works, either use `source.with_resources("resource_1")` or set the parameter directly on the resource. | ||||||||||||||
::: | ||||||||||||||
|
||||||||||||||
|
||||||||||||||
You can directly configure the `max_table_nesting` parameter on the resource level as: | ||||||||||||||
|
||||||||||||||
```py | ||||||||||||||
@dlt.resource(max_table_nesting=0) | ||||||||||||||
def my_resource(): | ||||||||||||||
... | ||||||||||||||
``` | ||||||||||||||
or | ||||||||||||||
```py | ||||||||||||||
my_source = source() | ||||||||||||||
my_source.my_resource.max_table_nesting = 0 | ||||||||||||||
``` | ||||||||||||||
|
||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. done |
||||||||||||||
### Modify schema | ||||||||||||||
|
||||||||||||||
The schema is available via `schema` property of the source. | ||||||||||||||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please, add an example how parameter could be set directly in the resource
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done