Docs/issue 1661 add tip to source docs and update weaviate docs #1662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dlt-hub-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
dat-a-man
changed the title
VioletM
requested changes
Aug 12, 2024
| @@ -116,6 +116,22 @@ weaviate_adapter( | |||
| tokenization={"title": "word", "description": "whitespace"}, | |||
| ) | |||
| ``` | |||
| When adapting resources, it's important to implement changes directly to the data source itself rather than extracting resources separately. Here's how: | |||
There was a problem hiding this comment.
Suggested change
| When adapting resources, it's important to implement changes directly to the data source itself rather than extracting resources separately. Here's how: | |
| When using the `weaviate_adapter`, it's important to apply it directly to resources, not to the whole source. Here's an example: |
| destination="weaviate", | ||
| ) | ||
|
|
||
| # adapt the resource within the source |
There was a problem hiding this comment.
Suggested change
| # adapt the resource within the source | |
| # apply adapter to the needed resources |
| :::tip TIP | ||
| The `max_table_nesting` parameter at the source level doesn't automatically apply to individual | ||
| resources when accessed directly (e.g., using `source.resources["resource_1"])`. To make sure it | ||
| works, either use `source.with_resources("resource_1")` or set the parameter directly on the resource. |
There was a problem hiding this comment.
please, add an example how parameter could be set directly in the resource
|
Also, please add the same info about adapter for qdrant https://deploy-preview-1662--dlt-hub-docs.netlify.app/docs/dlt-ecosystem/destinations/qdrant/#qdrant_adapter and lancedb https://deploy-preview-1662--dlt-hub-docs.netlify.app/docs/dlt-ecosystem/destinations/lancedb/#run-the-pipeline |
VioletM
requested changes
Aug 14, 2024
| products_tables = sql_database().with_resources("products", "customers") | ||
|
|
||
| pipeline = dlt.pipeline( | ||
| pipeline_name="postgres_to_weaviate_pipeline", |
There was a problem hiding this comment.
Suggested change
| pipeline_name="postgres_to_weaviate_pipeline", | |
| pipeline_name="postgres_to_lancedb_pipeline", |
|
|
||
| pipeline = dlt.pipeline( | ||
| pipeline_name="postgres_to_weaviate_pipeline", | ||
| destination="weaviate", |
There was a problem hiding this comment.
Suggested change
| destination="weaviate", | |
| destination="lancedb", |
| products_tables = sql_database().with_resources("products", "customers") | ||
|
|
||
| pipeline = dlt.pipeline( | ||
| pipeline_name="postgres_to_weaviate_pipeline", |
There was a problem hiding this comment.
Suggested change
| pipeline_name="postgres_to_weaviate_pipeline", | |
| pipeline_name="postgres_to_qdrant_pipeline", |
|
|
||
| pipeline = dlt.pipeline( | ||
| pipeline_name="postgres_to_weaviate_pipeline", | ||
| destination="weaviate", |
There was a problem hiding this comment.
Suggested change
| destination="weaviate", | |
| destination="qdrant", |
| ... | ||
| ``` | ||
|
|
||
|
|
There was a problem hiding this comment.
Suggested change
| or | |
| ```py | |
| my_source = my_source() | |
| my_source.my_resource.max_table_nesting = 0 |
VioletM
approved these changes
Aug 23, 2024
willi-mueller
pushed a commit
that referenced
this pull request
Sep 2, 2024
willi-mueller
pushed a commit
that referenced
this pull request
Sep 2, 2024
willi-mueller
pushed a commit
that referenced
this pull request
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#1661
This PR clarifies the behavior of the
max_table_nestingparameter, ensuring users understand that it doesn’t automatically apply to individual resources. It provides guidance on how to correctly apply the parameter to achieve the desired effect.