Use the latest available jdk #59788

ViktorHofer · 2025-01-09T07:54:45Z

ViktorHofer · 2025-01-09T12:57:46Z

@wtgodbe @BrennanConroy this will fix your builds (everything is broken right now). I opened dotnet/source-build#4816 to track how to best handle this going forward, including your local script to install a jdk.

We patched the VMR with this change to unblock builds.

global.json

wtgodbe · 2025-01-09T21:19:51Z

Whoa, github AI automatically populated an accurate commit description for my commit. Neat

BrennanConroy · 2025-01-09T22:48:03Z

src/SignalR/clients/java/signalr/build.gradle

@@ -22,7 +22,7 @@ allprojects {
    version project.findProperty('packageVersion') ?: "99.99.99-dev"

    java {
-        sourceCompatibility = 1.8
+        sourceCompatibility = 1.9


Why was this changed?

invalid source release: 9

See dotnet/sdk#45822 (comment)

We started hitting an error w/ version 8 when updating to 11.0.25:

EXEC : error : [options] source value 8 is obsolete and will be removed in a future release [D:\a\_work\1\vmr\src\aspnetcore\src\SignalR\clients\java\signalr\core\signalr.client.java.core.javaproj]

I'm not sure how to proceed if the underlying machines are in a mixed state, as they seem to be (some have 11.0.24, which is incompatible w/ 9, and some have 11.0.25, which is incompatible w/ 8)

Oh, never mind, it's Helix, not the build machines. Do you know why non-windows is on JDK 10 & windows is on 11 here? The Helix failure was only on Mac.

aspnetcore/eng/targets/Helix.targets

Lines 3 to 4 in e0e0224

<HelixPreCommand Condition="'$(IsWindowsHelixQueue)' == 'true'" Include="call RunPowershell.cmd InstallJdk.ps1 11.0.3 %25HELIX_CORRELATION_PAYLOAD%25\jdk && set %22JAVA_HOME=%25HELIX_CORRELATION_PAYLOAD%25\jdk%22" />

<HelixPreCommand Condition="'$(IsWindowsHelixQueue)' != 'true' AND '$(IsMacHelixQueue)' != 'true'" Include="./installjdk.sh 10.0.2 x64 && if [ "%24JAVA_HOME" = "" ]%3B then export JAVA_HOME=%24PWD/java%3B fi" />

I thought all machines were supposed to have moved to 21.X?

Probably should remove those lines now? Wonder if we used to have to install the jdk ourselves 5 years ago.

Oh, I totally missed that. So it looks like whatever version of macos-openjdk is pre-installed on the MacOS-13 queue isn't compatible w/ 1.9. @dotnet/dnceng does anyone know how we can check what version is installed on OSX.13.amd64.open? helix.dot.net doesn't list one.

Related to this ask?

dotnet/dnceng#4554

all macOS machines will have OpenJDK 8 and 21 after they are next refreshed

So maybe the machines haven't been refreshed?

Now we have

ERROR: JAVA_HOME is not set and no 'java' command could be found in your PATH.

On Windows 🙄

Should probably revert 3b86147

wtgodbe · 2025-01-10T16:41:37Z

invalid source release: 9

I think dnceng rolled back the machine updates, we might have to hold this until all machines have a JDK that supports 1.9

ViktorHofer · 2025-01-10T16:55:52Z

I think dnceng rolled back the machine updates, we might have to hold this until all machines have a JDK that supports 1.9

They rolled back yes, but the 1.9 sourceCompatibility setting works fine in the VMR with this patch. Are you sure that the current jdk that is installed on CI images don't support 1.9? Where do you see that failure?

akoeplinger · 2025-01-10T17:20:45Z

@ViktorHofer check the failed jobs. I think it works in the VMR because we're using AzureLinux 3.0 which likely comes with a new JDK, but the builds here are on Ubuntu 20.04 and according to helix.dot.net it only has openjdk-8-jdk again after the rollback.

ViktorHofer · 2025-01-10T18:04:36Z

Got it. Then I guess we just park this PR until the images get updated again and keep the patch in the VMR meanwhile.

wtgodbe · 2025-01-31T16:43:16Z

Actually wait, looks like we're already skipping the mac java tests in Helix, and the local mac failure was for NPM. Looks like that may be transient? Re-running to check

wtgodbe · 2025-01-31T17:48:40Z

Looks like the npm failure was unrelated. Filed #60139 to track re-enabling the Java tests on Mac.

wtgodbe · 2025-01-31T17:49:00Z

/backport to release/10.0-preview1

github-actions · 2025-01-31T17:49:12Z

Started backporting to release/10.0-preview1: https://github.com/dotnet/aspnetcore/actions/runs/13078023654

wtgodbe · 2025-01-31T18:08:17Z

We have a test failure that looks new - let's quarantine it & merge this to unblock CI

dougbu · 2025-01-31T18:34:33Z

any chance of getting the JDK updated/installed on the Mac build machines today?

none. we're in the midst of another rollout revert firedrill

BrennanConroy · 2025-01-31T18:36:01Z

Don't tell us the jdk update is going to be reverted...

dougbu · 2025-01-31T18:39:21Z

Don't tell us the jdk update is going to be reverted...

technically, yes it will be reverted. however it won't matter b/c the JDK installation on macOS only happens when machines are imaged. so, no macOS machines should have the new JDK and none will lose it. that's why I mentioned we'd need to work w/ DDFun

please file an issue in dotnet/dnceng and emphasize the urgency of getting this done on the macOS Helix machines. if you can't label the new issue there, let me know here. Needs Triage is probably the best one to apply though one of the Operations* or Ops* labels may help too

wtgodbe · 2025-01-31T18:41:46Z

technically, yes it will be reverted. however it won't matter b/c the JDK installation on macOS only happens when machines are imaged. so, no macOS machines should have the new JDK and none will lose it. that's why I mentioned we'd need to work w/ DDFun

What about on Windows/Linux? We needed this PR specifically because of the JDK updates there - if those updates are rolled back, we'll need to revert this (then un-revert it when the updates get re-rolled back out).

This reverts commit 28bad7a.

* Use the latest available jdk * Specify toolchain in build.gradle files * Try something else * Update InstallJdk.ps1 * Remove unused variable `$globalJson` in InstallJdk.ps1 * Update Helix.targets * Update GsonHubProtocolTest.java * Update Helix.targets * Add HelixPreCommand for non-Windows, non-Mac queues * Update signalr.client.java.Tests.javaproj * Update SkipHelixQueues for OSX.13.Amd64.Open --------- Co-authored-by: William Godbe <[email protected]> Co-authored-by: Brennan <[email protected]>

This reverts commit 28bad7a.

dougbu · 2025-02-02T21:33:39Z

technically, yes it will be reverted. however it won't matter b/c the JDK installation on macOS only happens when machines are imaged. so, no macOS machines should have the new JDK and none will lose it. that's why I mentioned we'd need to work w/ DDFun

What about on Windows/Linux? We needed this PR specifically because of the JDK updates there - if those updates are rolled back, we'll need to revert this (then un-revert it when the updates get re-rolled back out).

yup. those rolled back and the changes generally happened immediately. we have fewer Linux and Windows machines on-premises than we have VMs

This reverts commit 83da591.

) This reverts commit 83da591.

* Revert "Revert "Use the latest available jdk (#59788)" (#60143)" This reverts commit 83da591. * Update DelegateTests.cs --------- Co-authored-by: Viktor Hofer <[email protected]> Co-authored-by: Korolev Dmitry <[email protected]>

* Use the latest available jdk * Specify toolchain in build.gradle files * Try something else * Update InstallJdk.ps1 * Remove unused variable `$globalJson` in InstallJdk.ps1 * Update Helix.targets * Update GsonHubProtocolTest.java * Update Helix.targets * Add HelixPreCommand for non-Windows, non-Mac queues * Update signalr.client.java.Tests.javaproj * Update SkipHelixQueues for OSX.13.Amd64.Open --------- Co-authored-by: William Godbe <[email protected]> Co-authored-by: Brennan <[email protected]>

This reverts commit 28bad7a.

Use the latest available jdk

6f55fd1

dotnet-issue-labeler bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jan 9, 2025

ViktorHofer added 2 commits January 9, 2025 10:56

Specify toolchain in build.gradle files

3a3c11b

Try something else

ddd67f0

ViktorHofer mentioned this pull request Jan 9, 2025

Use latest jdk available in VMR aspnetcore build dotnet/sdk#45822

Merged

ViktorHofer marked this pull request as ready for review January 9, 2025 12:57

ViktorHofer requested review from BrennanConroy, halter73, wtgodbe and a team as code owners January 9, 2025 12:57

wtgodbe mentioned this pull request Jan 9, 2025

Update java to 11.0.25 #59794

Closed

wtgodbe reviewed Jan 9, 2025

View reviewed changes

global.json Show resolved Hide resolved

ViktorHofer and others added 2 commits January 9, 2025 22:17

Update InstallJdk.ps1

6fb3e6b

Remove unused variable $globalJson in InstallJdk.ps1

0ff7224

wtgodbe approved these changes Jan 9, 2025

View reviewed changes

halter73 approved these changes Jan 9, 2025

View reviewed changes

wtgodbe enabled auto-merge (squash) January 9, 2025 21:21

BrennanConroy reviewed Jan 9, 2025

View reviewed changes

wtgodbe and others added 3 commits January 9, 2025 15:23

Update Helix.targets

3b86147

Update GsonHubProtocolTest.java

2e2bd77

Update Helix.targets

fca0103

Add HelixPreCommand for non-Windows, non-Mac queues

475047d

This was referenced Jan 14, 2025

Checkout failure: "Git fetch failed with exit code 128" dotnet/arcade#9009

Open

Unable to checkout dotnet/dnceng#4115

Open

wtgodbe mentioned this pull request Jan 31, 2025

Re-enable Java SignalR tests on Mac #60139

Open

github-actions bot mentioned this pull request Jan 31, 2025

[release/10.0-preview1] Use the latest available jdk #60140

Merged

11 tasks

mkArtakMSFT mentioned this pull request Jan 31, 2025

Fixed the issue #60096

Merged

wtgodbe disabled auto-merge January 31, 2025 18:08

wtgodbe merged commit 28bad7a into main Jan 31, 2025
24 of 27 checks passed

wtgodbe deleted the ViktorHofer-patch-1 branch January 31, 2025 18:08

dotnet-policy-service bot added this to the 10.0-preview2 milestone Jan 31, 2025

wtgodbe added a commit that referenced this pull request Jan 31, 2025

Revert "Use the latest available jdk (#59788)"

f641eb6

This reverts commit 28bad7a.

wtgodbe mentioned this pull request Jan 31, 2025

Revert "Use the latest available jdk" #60143

Merged

wtgodbe added a commit that referenced this pull request Jan 31, 2025

Revert "Use the latest available jdk (#59788)" (#60143)

83da591

This reverts commit 28bad7a.

mkArtakMSFT pushed a commit that referenced this pull request Feb 1, 2025

Revert "Use the latest available jdk (#59788)" (#60143)

9f01e34

This reverts commit 28bad7a.

BrennanConroy mentioned this pull request Feb 6, 2025

[main] Update dependencies from dotnet/efcore, dotnet/runtime #60214

Merged

ViktorHofer added a commit that referenced this pull request Feb 6, 2025

Revert "Revert "Use the latest available jdk (#59788)" (#60143)"

a625ca5

This reverts commit 83da591.

github-actions bot pushed a commit that referenced this pull request Feb 6, 2025

Revert "Revert "Use the latest available jdk (#59788)" (#60143)"

725bd90

This reverts commit 83da591.

github-actions bot pushed a commit that referenced this pull request Feb 6, 2025

Revert "Revert "Use the latest available jdk (#59788)" (#60143)"

cd082b3

This reverts commit 83da591.

wtgodbe pushed a commit that referenced this pull request Feb 6, 2025

Revert "Revert "Use the latest available jdk (#59788)" (#60143)" (#60227

b9cbc17

) This reverts commit 83da591.

captainsafia pushed a commit that referenced this pull request Feb 11, 2025

Revert "Use the latest available jdk (#59788)" (#60143)

dd12668

This reverts commit 28bad7a.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use the latest available jdk #59788

Use the latest available jdk #59788

ViktorHofer commented Jan 9, 2025 •

edited

Loading

ViktorHofer commented Jan 9, 2025 •

edited

Loading

wtgodbe commented Jan 9, 2025 •

edited

Loading

BrennanConroy Jan 9, 2025

wtgodbe Jan 9, 2025

wtgodbe Jan 9, 2025

BrennanConroy Jan 9, 2025

BrennanConroy Jan 9, 2025

wtgodbe Jan 9, 2025 •

edited

Loading

sebastienros Jan 9, 2025

BrennanConroy Jan 9, 2025

BrennanConroy Jan 10, 2025

wtgodbe Jan 10, 2025

wtgodbe commented Jan 10, 2025

ViktorHofer commented Jan 10, 2025

akoeplinger commented Jan 10, 2025 •

edited

Loading

ViktorHofer commented Jan 10, 2025

wtgodbe commented Jan 31, 2025

wtgodbe commented Jan 31, 2025

wtgodbe commented Jan 31, 2025

github-actions bot commented Jan 31, 2025

wtgodbe commented Jan 31, 2025

dougbu commented Jan 31, 2025

BrennanConroy commented Jan 31, 2025

dougbu commented Jan 31, 2025

wtgodbe commented Jan 31, 2025

dougbu commented Feb 2, 2025

	<HelixPreCommand Condition="'$(IsWindowsHelixQueue)' == 'true'" Include="call RunPowershell.cmd InstallJdk.ps1 11.0.3 %25HELIX_CORRELATION_PAYLOAD%25\jdk && set %22JAVA_HOME=%25HELIX_CORRELATION_PAYLOAD%25\jdk%22" />
	<HelixPreCommand Condition="'$(IsWindowsHelixQueue)' != 'true' AND '$(IsMacHelixQueue)' != 'true'" Include="./installjdk.sh 10.0.2 x64 && if [ "%24JAVA_HOME" = "" ]%3B then export JAVA_HOME=%24PWD/java%3B fi" />

Use the latest available jdk #59788

Use the latest available jdk #59788

Conversation

ViktorHofer commented Jan 9, 2025 • edited Loading

ViktorHofer commented Jan 9, 2025 • edited Loading

wtgodbe commented Jan 9, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wtgodbe Jan 9, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wtgodbe commented Jan 10, 2025

ViktorHofer commented Jan 10, 2025

akoeplinger commented Jan 10, 2025 • edited Loading

ViktorHofer commented Jan 10, 2025

wtgodbe commented Jan 31, 2025

wtgodbe commented Jan 31, 2025

wtgodbe commented Jan 31, 2025

github-actions bot commented Jan 31, 2025

wtgodbe commented Jan 31, 2025

dougbu commented Jan 31, 2025

BrennanConroy commented Jan 31, 2025

dougbu commented Jan 31, 2025

wtgodbe commented Jan 31, 2025

dougbu commented Feb 2, 2025

ViktorHofer commented Jan 9, 2025 •

edited

Loading

ViktorHofer commented Jan 9, 2025 •

edited

Loading

wtgodbe commented Jan 9, 2025 •

edited

Loading

wtgodbe Jan 9, 2025 •

edited

Loading

akoeplinger commented Jan 10, 2025 •

edited

Loading