Skip to content

Fix F# compiler to prevent tail call emission when pinned locals are present #18893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 19, 2025
Merged

Fix F# compiler to prevent tail call emission when pinned locals are present #18893

merged 6 commits into from
Sep 19, 2025
+76 −2

Conversation

Copilot
Copy link
Contributor

@Copilot Copilot AI commented Sep 8, 2025 •
edited
Loading

  • Analyze PR review comments and understand required changes
  • Fix mutable variable issue in TailCallChecks.fs (use shadowed re-binding)
  • Remove .trx files from TestResults and update .gitignore
  • Add recursive test case to TailCalls.fs
  • Add release notes to FSharp.Compiler.Service markdown file
  • Run dotnet fantomas . to format code
  • Build and test to ensure all changes work correctly
  • Move release notes from 9.0.300.md to 10.0.100.md

💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

@Copilot Copilot AI assigned Copilot and T-Gro Sep 8, 2025
@Copilot Copilot AI changed the title [WIP] F# Compiler Tailcall Suppression Fix for Pinned Locals Fix F# compiler to prevent tail call emission when pinned locals are present Sep 8, 2025
@Copilot Copilot AI requested a review from T-Gro September 8, 2025 16:43
Copilot finished work on behalf of T-Gro September 8, 2025 16:43
T-Gro
T-Gro requested changes Sep 17, 2025
View reviewed changes
Copy link
Member

@T-Gro T-Gro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments above.
Also, you will need to add release notes to the FSharp.Compiler.Service markdown file.
Also, run "dotnet fantomas ." in the repo root at the end of your work.

@github-project-automation github-project-automation bot moved this from New to In Progress in F# Compiler and Tooling Sep 17, 2025
@Copilot @T-Gro
Fix PR review comments: remove mutable, gitignore .trx files, add rec…
3c000d9 
…ursive test, add release notes, format code

Co-authored-by: T-Gro <[email protected]>
@Copilot Copilot SWE Agent
Copy link
Contributor Author

Copilot AI commented Sep 17, 2025

See comments above.
Also, you will need to add release notes to the FSharp.Compiler.Service markdown file.
Also, run "dotnet fantomas ." in the repo root at the end of your work.

All feedback addressed: fixed mutable variable usage, removed .trx files, added recursive test case, added release notes to FSharp.Compiler.Service, and ran dotnet fantomas. Commit: 3c000d9

@Copilot Copilot AI requested a review from T-Gro September 17, 2025 17:51
Copilot finished work on behalf of T-Gro September 17, 2025 17:51
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 18, 2025 •
edited
Loading

❗ Release notes required

✅ Found changes and release notes in following paths:

Warning

No PR link found in some release notes, please consider adding it.

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/10.0.100.md No current pull request URL (#18893) found, please consider adding it

T-Gro
T-Gro reviewed Sep 18, 2025
View reviewed changes
@Copilot Copilot AI requested a review from T-Gro September 18, 2025 08:36
Copilot finished work on behalf of T-Gro September 18, 2025 08:36
@T-Gro T-Gro marked this pull request as ready for review September 18, 2025 09:09
@T-Gro T-Gro requested a review from a team as a code owner September 18, 2025 09:09
@T-Gro T-Gro mentioned this pull request Sep 19, 2025
Closed
@abonie abonie merged commit 1de7a62 into main Sep 19, 2025
40 checks passed
@T-Gro T-Gro deleted the copilot/fix-61d24601-bf92-422f-8e60-9685bd58e976 branch September 22, 2025 09:11
@T-Gro T-Gro mentioned this pull request Sep 22, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abonie abonie abonie approved these changes

+1 more reviewer

@T-Gro T-Gro T-Gro approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@T-Gro T-Gro

Copilot code review Copilot

Labels
None yet
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Copilot @abonie @T-Gro